I've pushed the mentioned changes to <https://gith...
# hacktoberfest-2022
b
I've pushed the mentioned changes to https://github.com/flyteorg/flytekit/pull/1269/files @tall-lock-23197
t
Thanks, @billowy-continent-33554! Will review the changes and get back to you.
b
I don't have any checks (0 checks) on my PR, is something wrong here?
it says no jobs to run @high-accountant-32689
t
Um yeah; I see that too! Can you do a force push?
b
Okay, so i just updated my fork and it fixed it
t
Hey. We shouldn’t be using
tensor_dtype
as class variable in this case because it needs to be set a different value within
to_literal
method and that won’t be known to
to_python_value
method. If you want to work on this, you’ll need to send
tensor_dtype
as
format
of the blob.
b
I've made the suggested changes, please have a look
t
Thanks!
b
I hope the changes are correct?
t
LGTM! I’ll merge it soon.
157 Views