https://flyte.org logo
#hacktoberfest-2022
Title
# hacktoberfest-2022
c

cryptic

11/14/2022, 8:24 AM
I've pushed the mentioned changes to https://github.com/flyteorg/flytekit/pull/1269/files @Samhita Alla
s

Samhita Alla

11/14/2022, 8:52 AM
Thanks, @cryptic! Will review the changes and get back to you.
c

cryptic

11/19/2022, 5:11 AM
I don't have any checks (0 checks) on my PR, is something wrong here?
it says no jobs to run @Eduardo Apolinario (eapolinario)
s

Samhita Alla

11/19/2022, 10:46 AM
Um yeah; I see that too! Can you do a force push?
c

cryptic

11/19/2022, 12:49 PM
Okay, so i just updated my fork and it fixed it
s

Samhita Alla

11/21/2022, 5:20 AM
Hey. We shouldn’t be using
tensor_dtype
as class variable in this case because it needs to be set a different value within
to_literal
method and that won’t be known to
to_python_value
method. If you want to work on this, you’ll need to send
tensor_dtype
as
format
of the blob.
c

cryptic

11/21/2022, 12:08 PM
I've made the suggested changes, please have a look
s

Samhita Alla

11/21/2022, 12:41 PM
Thanks!
c

cryptic

11/21/2022, 12:42 PM
I hope the changes are correct?
s

Samhita Alla

11/21/2022, 1:06 PM
LGTM! I’ll merge it soon.
78 Views