https://flyte.org logo
Join the conversationJoin Slack
Channels
announcements
ask-the-community
auth
conference-talks
contribute
databricks-integration
datahub-flyte
deployment
ecosystem-unionml
engineeringlabs
events
feature-discussions
flyte-bazel
flyte-build
flyte-console
flyte-deployment
flyte-documentation
flyte-github
flyte-ui-ux
flytekit
flytekit-java
flytelab
great-content
hacktoberfest-2022
helsing-flyte
in-flyte-conversations
introductions
jobs
konan-integration
linkedin-flyte
random
ray-integration
ray-on-flyte
release
scipy-2022-sprint
sig-large-models
workflow-building-ui-proj
writing-w-sfloris
Powered by Linen
hacktoberfest-2022
  • t

    Thusal Ranawaka

    10/15/2022, 10:54 AM
    Hi, I am a newbie to this Flyte Project, I can contribute for Flyte in documentation.
    s
    • 2
    • 1
  • r

    Ryan Nazareth

    10/18/2022, 1:03 PM
    Hello Flyte team, Ive updated and added a few PRs https://github.com/flyteorg/flytekit/pull/1240 https://github.com/flyteorg/flytekit/pull/1230 and had an initial go at adding an NLP tutorial but not sure why some of the tests are failing https://github.com/flyteorg/flytesnacks/pull/911/files
    s
    d
    • 3
    • 4
  • s

    Samhita Alla

    10/19/2022, 3:59 PM
    @Kevin Su, could you please review https://github.com/flyteorg/flytekit/pull/1230 PR?
  • s

    Samhita Alla

    10/20/2022, 6:13 AM
    @Eduardo Apolinario (eapolinario) @Kevin Su, please review https://github.com/flyteorg/flytekit/pull/1236 PR.
  • a

    Aditya Bisht

    10/24/2022, 5:49 PM
    Wanted to know that this issue https://github.com/flyteorg/flyte/issues/2908 is for this repo https://github.com/flyteorg/flyteconsole right?
    k
    • 2
    • 1
  • s

    Samhita Alla

    10/25/2022, 12:30 PM
    Hey @Niels Bantilan! Regarding https://github.com/flyteorg/flyte/issues/2759,
    tf.Module
    is the parent class for
    tf.keras.layers.Layer
    and
    tf.keras.Model
    (see the note on https://www.tensorflow.org/guide/intro_to_modules page). So we need a type transformer for
    tf.Module
    . But we have two PRs — https://github.com/flyteorg/flytekit/pull/1242 to fix https://github.com/flyteorg/flyte/issues/2759 and https://github.com/flyteorg/flytekit/pull/1241 to fix https://github.com/flyteorg/flyte/issues/2570 that have the same functionality — a type transformer subclassing
    tf.keras.Model
    . We’ll need to tell one of them to modify the code. So which PR shall we retain?
  • s

    Samhita Alla

    10/25/2022, 1:07 PM
    Can someone review https://github.com/flyteorg/flytetools/pull/66 PR, please?
  • s

    Samhita Alla

    10/25/2022, 1:45 PM
    Also @Niels Bantilan, regarding https://github.com/flyteorg/flytekit/pull/1240, are there any use cases you could think of?
    n
    r
    d
    • 4
    • 10
  • r

    Ryan Nazareth

    10/26/2022, 3:39 AM
    I am trying to run the script in my flytesnacks PR https://github.com/flyteorg/flytesnacks/pull/911 on a flyte demo cluster to check out the flytedeck plot but i am getting an error - seems like the kubernetes pods are not responding ? (see screenshot below) ive created the demo cluster as per the instructions in the docs https://docs.flyte.org/en/latest/getting_started/index.html#creating-a-demo-flyte-cluster and exported
    KUBECONFIG
    and
    FLYTECTL_CONFIG
    environment variable values which were printed out after the cluster was setup. Do i need to login to the kubernetes ui and/or configure anything else ?
    k
    s
    • 3
    • 5
  • s

    Sriniketh J

    10/26/2022, 5:54 AM
    Hey team!! I wanted my blog to be reviewed. Here is the link: https://dev.to/srini047/what-is-data-orchestration-4kfb-temp-slug-7953970?preview=44f2a4a274977f9272ea655b1c6839766e9d423bd8ae68c54d7223fba32443a0094b8e7455b66550cb1c5ad94e5d3eab3465b770d3b6de80b2574723
    s
    • 2
    • 4
  • s

    Samhita Alla

    10/26/2022, 7:29 AM
    @Eduardo Apolinario (eapolinario) @Kevin Su, can https://github.com/flyteorg/flytekit/pull/1236 be merged? Also Eduardo, do you think
    typing.TypeVar
    needs to be replaced with
    typing.Annotated
    in FlyteFile even if it isn’t throwing any mypy errors?
    e
    • 2
    • 4
  • c

    cryptic

    10/27/2022, 5:30 AM
    One of the tests on GA is failing due to pytest not being recognized as a command on Windows build (Python 3.7 -spark2) (https://github.com/flyteorg/flytekit/actions/runs/3326738618/jobs/5511139310#step:6:12)
    e
    • 2
    • 38
  • s

    Samhita Alla

    10/27/2022, 7:05 AM
    https://github.com/flyteorg/flytekit/pull/1258#issuecomment-1293083159; @Niels Bantilan @Kevin Su @Eduardo Apolinario (eapolinario), would like to know your thoughts.
  • s

    Samhita Alla

    10/27/2022, 8:54 AM
    @Ryan Nazareth @Kevin Su, left two comments on https://github.com/flyteorg/flytekit/pull/1230 PR. Let me know what you think.
  • s

    Samhita Alla

    10/27/2022, 9:57 AM
    @Kevin Su, apologies for the constant pings 😅. Can you take a look at https://github.com/flyteorg/flytekit/pull/1241#issuecomment-1293274305 comment when you find the time?
  • r

    Ryan Nazareth

    10/27/2022, 10:50 PM
    @FlyteCoreTeam Having another issue when running one of the tasks for the nlp PR. https://github.com/flyteorg/flytesnacks/pull/911 on demo cluster with custom built image I am getting this error for some of the downstream tasks which take the serialised flytefile (
    .model
    ) as input:
    Pod failed. No message received from kubernetes.
    [fb8f63b27ec284bbfbc8-n3-0] terminated with exit code (137). Reason [Error]. Message:
    `tar: Removing leading
    /' from member names
    See screenshot below. The error seems like its trying to extract something from tar archive but Im not doing this anywhere in my task logic ? Also, think someone else has reported this error as well https://flyte-org.slack.com/archives/CP2HDHKE1/p1664441568396559?thread_ts=1664433734.963769&cid=CP2HDHKE1
    e
    n
    • 3
    • 3
  • s

    Samhita Alla

    10/28/2022, 4:40 AM
    @Kevin Su / @Eduardo Apolinario (eapolinario), need a +1: https://github.com/flyteorg/flytekit/pull/1230
  • s

    Samhita Alla

    10/28/2022, 6:00 AM
    @Prafulla Mahindrakar, can I get a +1 for https://github.com/flyteorg/flyte/pull/3033 PR? It fixes the issue you filed.
  • c

    cryptic

    10/28/2022, 6:40 AM
    @Eduardo Apolinario (eapolinario) Would it be a proper way to serialize tensors using pickle?
    s
    • 2
    • 14
  • c

    cryptic

    10/28/2022, 10:25 AM
    @Samhita Alla I have one last question, how do I fix lint errors on
    make lint
    ? I'm sorry but I'm not quite sure about it (https://github.com/flyteorg/flytekit/actions/runs/3326738618/jobs/5511140308#step:6:360)
    s
    • 2
    • 14
  • c

    cryptic

    10/28/2022, 5:34 PM
    @Samhita Alla I'm done pushing the mentioned changes except for linting issues. I was unable to sign off properly because I messed up my pre-commit hooks, will GA run?
    k
    e
    s
    • 4
    • 9
  • r

    Ryan Nazareth

    10/28/2022, 9:32 PM
    Just checking if this channel will still be open after Hacktoberfest ends on Monday ? I may have PRs outstanding beyond that date, so may still have queries
    k
    • 2
    • 5
  • s

    Samhita Alla

    10/31/2022, 12:29 PM
    @Eduardo Apolinario (eapolinario) @Yee @Kevin Su Is it possible to use
    LiteralCollection
    with multiple literal types? If so, how should the
    get_literal_type
    method be defined since
    collection_type
    can only accept a single
    LiteralType
    ? See https://github.com/flyteorg/flytekit/pull/1269/files PR for reference.
    k
    c
    • 3
    • 32
  • r

    Ryan Nazareth

    11/09/2022, 10:53 AM
    Just a note, I’m still working on https://github.com/flyteorg/flytekit/pull/1240/files just been a bit busy these past few weeks. I’ll hopefully get it done before this channel closes 😁
    k
    • 2
    • 1
  • c

    cryptic

    11/12/2022, 5:06 AM
    I have filled out the form but haven't received any confirmation mail yet, can i expect any kind of confirmation?
    s
    • 2
    • 2
  • r

    Ryan Nazareth

    11/13/2022, 2:48 AM
    Pushed some changes to https://github.com/flyteorg/flytekit/pull/1240 and made some comments as im struggling a bit with the design (and getting the tests to pass). ☹️
    s
    • 2
    • 2
  • c

    cryptic

    11/14/2022, 8:24 AM
    I've pushed the mentioned changes to https://github.com/flyteorg/flytekit/pull/1269/files @Samhita Alla
    s
    • 2
    • 10
  • r

    Ryan Nazareth

    11/23/2022, 2:28 PM
    Hi all, i have a question regarding the type annotations in workflow tasks. I am having an issue in https://github.com/flyteorg/flytekit/pull/1240, where the test for the workflow for
    tests/flytekit/unit/extras/tensorflow/record/test_record.py
    , which has tasks to generate TFRecordFile and TFRecordDirectory from tf.train.Example outputs and subsequently deserialise back to
    tf.data.TFRecordDataset
    if required. The bit thats causing an error is
    @task
    def consume(dataset: Annotated[TFRecordDatasetV2, TFRecordDatasetConfig(name="testing")]):
    which, seems to not be recognising the Annotated TFRecordDatasetV2 type although it should be the expected type in the transformers i have registered here flytekit/extras/tensorflow/record.py. I presume this is why it is defaulting to FlytePickle as in the traceback (this is only my assumption and based on some other logic i have seen elsewhere in the codebase). Also, my other test
    tests/flytekit/unit/extras/tensorflow/record/test_transformations.py
    which is testing the
    to_python_value
    and
    to_literal
    logic works fine so i feel something else is an issue which I am finding difficult to spot at the moment.
    expected_python_type = typing.Annotated[flytekit.types.pickle.pickle.FlytePickle.__class_getitem__.<locals>._SpecificFormatClass, TFRecordDatasetConfig(compression_type=None, buffer_size=None, num_parallel_reads=None, name='testing')]
    
        def to_python_value(self, ctx: FlyteContext, lv: Literal, expected_python_type: Type[T]) -> T:
            uri = lv.scalar.blob.uri
            # Deserialize the pickle, and return data in the pickle,
            # and download pickle file to local first if file is not in the local file systems.
            if ctx.file_access.is_remote(uri):
                local_path = ctx.file_access.get_random_local_path()
                ctx.file_access.get_data(uri, local_path, False)
                uri = local_path
            with open(uri, "rb") as infile:
    >           data = cloudpickle.load(infile)
    E           _pickle.UnpicklingError: invalid load key, '5'.
    k
    s
    • 3
    • 20
  • r

    Ryan Nazareth

    11/29/2022, 10:00 PM
    Hello Flyte core team, once this channel is archived, is there another channel/discord where contributors discuss PRs/issues etc. or is it mainly on github ? Ive noticed the other channels on slack are mainly for end users queries. I intend to tackle a few more issues further down the line (maybe early next year) and propose a few new features (mainly flyte and other cloud services integration), so was wondering which medium is used for discussion.
    k
    • 2
    • 2
  • s

    Samhita Alla

    02/17/2023, 11:47 AM
    archived the channel
Powered by Linen
Title
s

Samhita Alla

02/17/2023, 11:47 AM
archived the channel
View count: 3