Channels
#hacktoberfest-2022
Title
# hacktoberfest-2022
c
cryptic
10/28/2022, 5:34 PM@Samhita Alla I'm done pushing the mentioned changes except for linting issues. I was unable to sign off properly because I messed up my pre-commit hooks, will GA run?
@Eduardo Apolinario (eapolinario) Can my GA builds be run if the DCO check failed? I've to fix my git before rebasing my commits
k
Kevin Su
10/28/2022, 10:10 PMyes, it can. could you share the link of the pr?
e
Eduardo Apolinario (eapolinario)
10/28/2022, 10:36 PM@Kevin Su, https://github.com/flyteorg/flytekit/pull/1243 is the PR. I approved the tests.
c
cryptic
10/29/2022, 9:18 AM@Kevin Su I've given a go at fixing my linting errors, can the GA builds be re-run?
@Eduardo Apolinario (eapolinario) Please approve my tests, i've fixed linting errors
@Ketan (kumare3) Can you please approve my tests?
I've messed up my previous PR, while trying to fix an unexpected dep issue with flyteidl, i've opened a fresh one #1269 (https://github.com/flyteorg/flytekit/pull/1269/)
Please allow tests to run @Eduardo Apolinario (eapolinario) (Sorry for the multiple pings, i'm trying to fix issues ASAP)
@Kevin Su Sorry for bothering again, can my tests be approved? Yesterday i'd to face an unexpected dependency issue with flyteidl versioning (#2522), i'd messed up my previous PR so i've opened a new PR here with all the changes (https://github.com/flyteorg/flytekit/pull/1269/)
s
Samhita Alla
10/31/2022, 4:31 AM
@cryptic, I’ll review your changes. Give me some time.