https://flyte.org logo
#hacktoberfest-2022
Title
# hacktoberfest-2022
s

Samhita Alla

10/26/2022, 7:29 AM
@Eduardo Apolinario (eapolinario) @Kevin Su, can https://github.com/flyteorg/flytekit/pull/1236 be merged? Also Eduardo, do you think
typing.TypeVar
needs to be replaced with
typing.Annotated
in FlyteFile even if it isn’t throwing any mypy errors?
e

Eduardo Apolinario (eapolinario)

10/26/2022, 5:35 PM
I don't believe we should go ahead with this change. Simply replacing mentions to typevar with raw strings is going to start showing up as errors in mypy.
s

Samhita Alla

10/27/2022, 4:11 AM
e

Eduardo Apolinario (eapolinario)

10/27/2022, 5:33 AM
left a comment in the PR
32 Views