Hi! I was looking at this metric from propeller ca...
# announcements
s
Hi! I was looking at this metric from propeller called
grpc_client_handled_total
but I only see requests to the AdminService, is there a way to see requests to datacatalog as well?
p
Currently those are not being captured. Admin ones are captured through this interceptor, but i believe since this is part of idl hence the metric would capture client handled total including propeller, flytectl or any other client which consumes this grpc code https://github.com/flyteorg/flyteidl/blob/654427ef4027c6b48d997abe8770c2e8b915e84a/clients/go/admin/client.go#L81 We can add one for datacatalog here https://github.com/flyteorg/flytepropeller/blob/0301f2a216001bdb988eef4ae58293f525[…]d3/pkg/controller/nodes/task/catalog/datacatalog/datacatalog.go
s
ok thank you! Would be nice to see this for datacatalog too. I think
grpc_client_handled_total
also only counts number of calls right? So to get latency we would need to do something like
grpc_prometheus.EnableHandlingTimeHistogram()
according to the docs?
p
Do you mind opening an issue for this . Both the issues can be combined.. We can get more opinions on whether its ok to enable latency numbers which are disabled by default
s
.
I’ll open an issue
🙏 1
109 Views