hi has this metric been renamed recently `flyte a

Question

hi has this metric been renamed recently < katrina> `flyte admin task execution manager task executions terminated counter`

katrina · Answer

I don t believe it s been touched since the work you did to add the error kind what are you seeing

Alex Pozimenko · Answer

I added error kind to this one note it s different from the above `flyte admin admin execution manager executions terminated counter` and the one i was asking about doesn t show any data

katrina · Answer

ah task vs workflow executions gotcha

katrina · Answer

this has changed <https github com flyteorg flyteadmin pull 386 files diff 9b311b663f43eccf79220bfcae3a565ad26d83532c945f39cfc1f7ba029c22e3R1651>

Alex Pozimenko · Answer

i see it was labeled with phase but did the name change too

katrina · Answer

i don t believe it should be

katrina · Answer

although under the hood a labeled counter is using a CounterVec which actually scopes the metric name apparently so this could have changed it

Alex Pozimenko · Answer

could this be the new name `flyte admin admin task execution manager task executions terminated counter`

katrina · Answer

yeah that looks suspiciously like the scope

katrina · Answer

sorry about this i think we missed calling this out in corresponding release notes disappointed

Alex Pozimenko · Answer

np thanks for confirming