https://flyte.org logo
a

Alex Pozimenko

05/12/2022, 7:03 PM
hi, has this metric been renamed recently? (@katrina)
flyte-admin-task.execution.manager-task.executions.terminated.counter
k

katrina

05/12/2022, 7:06 PM
I don't believe it's been touched since the work you did to add the error kind. what are you seeing?
a

Alex Pozimenko

05/12/2022, 7:09 PM
I added error kind to this one (note, it's different from the above):
flyte-admin-admin-execution.manager-executions.terminated.counter
and the one i was asking about doesn't show any data
k

katrina

05/12/2022, 7:10 PM
ah task vs workflow executions, gotcha
✔️ 1
a

Alex Pozimenko

05/12/2022, 7:12 PM
i see it was labeled with phase, but did the name change too?
k

katrina

05/12/2022, 7:15 PM
i don't believe it should be
although under the hood, a labeled counter is using a CounterVec which actually scopes the metric name apparently, so this could have changed it
a

Alex Pozimenko

05/12/2022, 7:18 PM
could this be the new name?
flyte-admin-admin-task.execution.manager-task.executions.terminated.counter
k

katrina

05/12/2022, 7:19 PM
yeah, that looks suspiciously like the scope
sorry about this, i think we missed calling this out in corresponding release notes 😞
a

Alex Pozimenko

05/12/2022, 7:20 PM
np, thanks for confirming
7 Views