hi, has this metric been renamed recently? (<@UPBB...
# announcementsa
Alex Pozimenko
05/12/2022, 7:03 PMhi, has this metric been renamed recently? (@katrina)
flyte-admin-task.execution.manager-task.executions.terminated.counterk
katrina
05/12/2022, 7:06 PM
I don't believe it's been touched since the work you did to add the error kind. what are you seeing?
a
Alex Pozimenko
05/12/2022, 7:09 PMI added error kind to this one (note, it's different from the above):
flyte-admin-admin-execution.manager-executions.terminated.counterk
katrina
05/12/2022, 7:10 PM
ah task vs workflow executions, gotcha
✔️ 1
katrina
05/12/2022, 7:11 PM
a
Alex Pozimenko
05/12/2022, 7:12 PMi see it was labeled with phase, but did the name change too?
k
katrina
05/12/2022, 7:15 PM
i don't believe it should be
katrina
05/12/2022, 7:17 PM
although under the hood, a labeled counter is using a CounterVec which actually scopes the metric name apparently, so this could have changed it
a
Alex Pozimenko
05/12/2022, 7:18 PMcould this be the new name?
flyte-admin-admin-task.execution.manager-task.executions.terminated.counterk
katrina
05/12/2022, 7:19 PM
yeah, that looks suspiciously like the scope
katrina
05/12/2022, 7:20 PM
sorry about this, i think we missed calling this out in corresponding release notes 😞
a
Alex Pozimenko
05/12/2022, 7:20 PMnp, thanks for confirming
168 Views