https://flyte.org logo
Join Slack
Powered by
Hi team! Can you please review this small PR to f...
# contribute
a
Hi team! Can you please review this small PR to fix a flytekit issue? https://github.com/flyteorg/flytekit/pull/3230 (already have one approve from @glamorous-carpet-83516)
d
Hi I can help
Can you add some unit tests?
Kevin is on vacation, ping me plz
a
sure
d
before I approve CI, you can run 
make unit_test
to make sure all unit tests will pass
a
I guess I just need to setup a venv with dev-requirements.txt and run 
make unit_test
correct?
@damp-lion-88352 unit tests updated and added
@damp-lion-88352 unit test simplified and lint issue fixed, can you pls check it again?
@damp-lion-88352 thanks for merging the changes! any chance to get this fix backported to flytekit 1.14 and release it? is there anything I can do for this?
g
@aloof-painting-18735 could you use v1.16.0b7? https://github.com/flyteorg/flytekit/releases/tag/v1.16.0b7
or you want to use 1.14
a
Now, we have Flyte v1.14.1 deployed in PROD, we want to use a flytekit that is compatible with that version. I guess it would be recommended to use flytekit 1.14.x, that's why I requested backporting. If backporting is painful and v1.16.0 is expected to be also compatible, we can run a test with 
v1.16.0b7
and go production with the stable 
v1.16.0
release.
g
yes, I think it’s okay for us to cut a patch release for flytekit 1.14
a
cool, thanks a lot!
g
a
thanks a lot!
Open in Slack
PreviousNext
Powered by