Rafael and I just discussed the idea of using `Con...
# flyte-connectors
d
Rafael and I just discussed the idea of using
ContainerError
in Flytekit's agent service, and I completely agree with the suggestion. I'd love to hear what others think about it. For reference: - ContainerError: https://github.com/flyteorg/flyte/blob/master/flyteidl/protos/flyteidl/core/errors.proto#L13-L24 - Agent service: https://github.com/flyteorg/flytekit/blob/master/flytekit/extend/backend/agent_service.py
b
Happy to try and implement it. 🙂 Even though it's not a
ContainerError
since it's a not a container, but the usecase here is that porting a task from pod to agent, as it is right now it would be a breaking change. We evaluate the fields under the
ContainerError
to evaluate if we need to retry or not.
a
Thanks for sharing. For the benefit of anyone reading this: why porting from pod to agent would be a breaking change?
b
The breaking change is how it's reporting the errors back. As it stands right now I would have to include it in the message or in the Custom Field that I forget the name. Ideally if we had this https://github.com/flyteorg/flyte/blob/master/flyteidl/protos/flyteidl/core/execution.proto#L61 that would be sweet
Ok so if I understood correctly. https://github.com/flyteorg/flyte/pull/5916 Here's a good way, still not totally convinced we would need all those fields but is customisable now.