Hey folks, we found a problem on how the SyncAgent...
# flyte-connectorsb
brief-window-55364
10/22/2024, 9:31 AMHey folks, we found a problem on how the SyncAgent grpc client is streaming into the grpc server. I've proposed a fix here https://github.com/flyteorg/flyte/pull/5884 issue: https://github.com/flyteorg/flyte/issues/5885. cc: @damp-lion-88352
f
freezing-airport-6809
10/22/2024, 1:54 PM
This is a bad big, but where do we use streaming
b
brief-window-55364
10/22/2024, 1:55 PMI found out when trying to implement the SyncAgentService. I'm not sure how you folks implemented it in flytekit, it seems some magic iterating stuff happening there.
d
damp-lion-88352
10/22/2024, 1:56 PMdamp-lion-88352
10/22/2024, 1:57 PMwe didn;t support streaming agent yet
damp-lion-88352
10/22/2024, 1:57 PMlangchain will be supported in the future
b
brief-window-55364
10/22/2024, 1:58 PMWe're probably talking about different streamings xD
d
damp-lion-88352
10/22/2024, 1:59 PMcan you say more?>
b
brief-window-55364
10/22/2024, 1:59 PMThis is the streaming I'm talking about https://grpc.io/docs/languages/go/basics/#client-side-streaming-rpc-1
brief-window-55364
10/22/2024, 2:04 PMYou're sending the ExecuteTaskSyncRequest in two different calls. So basically server side I'm using the onNext (Java implementation) to capture thoses but since the call never closes, it doesn't move over to the onCompleted.
brief-window-55364
10/22/2024, 2:19 PMhttps://docs.python.org/3/library/collections.abc.html#collections.abc.AsyncIterator you're somewhat doing the same with typing, you just handle things straight away once you have both the templates and request https://github.com/flyteorg/flytekit/blob/61b58966188d5d33bc6ab4af209f647de0b51995/flytekit/extend/backend/agent_service.py#L164C17-L164C24. It would be best to have my change so we know when the client stopped sending data and we can process accordingly.
brief-window-55364
10/22/2024, 2:45 PMAlso @freezing-airport-6809 it's not a critical bug per-se, it's just when implementing things ourselves things aren't properly done. We can work around it but would prefer to do it properly.
7 Views