https://flyte.org logo
Join Slack
Powered by
Hi Flyte community, there is pull request opened f...
# contribute
a
Hi Flyte community, there is pull request opened from me: https://github.com/flyteorg/flyte/pull/5535. There are a few issues with this Merge Request that I can only partly solve: • https://github.com/flyteorg/flyte/actions/runs/10138813865/job/28636609597?pr=5535 Here gosec complains about disabling the TLS verification. This is intentional and I have followed https://github.com/securego/gosec?tab=readme-ov-file#annotating-code in order to skip the warning, but it does not work. • Another step also fails but not related to any changes that I did: https://github.com/flyteorg/flyte/actions/runs/10138813865/job/28636604593?pr=5535 • There is also an issue with code coverage that I will have issue to solve because based on the nature of the code it is extremly hard to provide tests for it Can we find a way to solve those issues so that the merge request can move forward in the pipeline?
t
put nosec above?
Copy code
// #nosec G402
	tlsConfiguration = &tls.Config{
		InsecureSkipVerify: emailConf.SMTPSkipTLSVerify,
		ServerName:         emailConf.SMTPServer,
	}
that should work
mind running go mod tidy and make lint-fix in flyteadmin as well please?
a
Hi @thankful-minister-83577, sorry for replying that late. I simply missed that there were activities on the thread. The dependencies are already cleared using 
go mod tidy
. Running the linter 
make lint-fix
leads to an error of the underlying linter
Copy code
ERRO Running error: 1 error occurred:
        * can't run linter goanalysis_metalinter: goanalysis_metalinter: buildir: package "slices" (isInitialPkg: false, needAnalyzeSource: true): Cannot range over: func(yield func(E) bool)

INFO Memory: 331 samples, avg is 133.2MB, max is 1181.1MB
INFO Execution took 32.904025633s
make: *** [../boilerplate/flyte/golang_test_targets/Makefile:18: lint] Error 3
It is by the way super annoying, that every CI build needs to be approved
t
sorry for the delay. would you mind running lint one more time?
since it looks like a company github i assume you won’t be able to give me write access. and apologies for the manual approval.
Open in Slack
PreviousNext
Powered by