Just to loop back on extending the agent to get pa...
# contribute
g
Just to loop back on extending the agent to get passed identity (flytekit PR https://github.com/flyteorg/flytekit/pull/2315) based on the work done in https://github.com/flyteorg/flyte/pull/5105 to add Identity to the IDL We recently discovered that we need both the securityContext and the metadata.principal (when flytescheduler triggers the job thats the identity, but we really need to use principal for our use case) Was this part of what the team wanted to discuss on that PR @average-finland-92144? I'll be following up sometime in the next week to extend the IDL to support the principal as well -- will give you a heads up when that PR is ready
f
cc @glamorous-carpet-83516
g
reviewing
Hey @gorgeous-waitress-5026 btw, is this pr ready for review? if so, I’ll take a look tomorrow.
g
Thanks @glamorous-carpet-83516! On the
custom_info
for that PR, I wasn't able to get that one working... yet -- I believe there's something missing on the Flyteadmin side to record that info. The log_links are sent back in a similar fashion and get updated for the task, but I'm not sure where
custom_info
is recorded to Postgres. I started tracing those code paths, but had to switch gears and work on something else -- but I should be taking another look shortly. I think what I did in flytekit is correct -- but without the flyteadmin piece working, it's hard to be certain (without intercepting and inspecting the grpc messages)