We have some workflows that seem to be triggering a memory leak in flytepropeller. Within a dynamic task there's a map task sometimes with up to ~5000 subtasks, and even though the subtasks all say succeeded, the map task doesn't for a very long time (sometimes it eventually does). In the meantime memory in flytepropeller keeps rising and even if the map task eventually succeeds or is aborted the memory usage remains. Possibly we're making some connections that aren't there between the memory usage and the workflows, but just wondering if someone has seen anything like that or has any ideas what could be happening?

are you using the legacy/old map tasks or the array node map task implementation?

Legacy map tasks and the memory usage does remain elevated after it succeeds or we abort them (though it stops going up)

@hallowed-camera-82098 Flytepropeller has a big cache - that is greedy and will go up with usage. It gc's at 70% of usage (default) you can adjust this. This is usually not a leak but by design

We think we mitigated this by disabling cache in the flyte workflow, Not sure if this is helpful, here's heap diagram (diff_based against 35 minutes earlier while the memory usage was steadily rising)

close to 5GB in task handler

The total size of inputs.pb to these map tasks weighs in at ~7MB. Outputs are even smaller, O(100 bytes) per task, just a GCS path

this is not good, would love to see an example of the workflow

7MB is the total inputs.pb to the map task

it does not need it

The workflow is really rather simple

Oh just noticed the 70% gc comment, forgot to mention we were actually OOMing, even with 128Gi

outputs.pb of that

create_map_inputs

run is 7MB, corresponds to 4.7k tasks in the map task

I think it’s not about simple or complex we will Have to see the actual values

Mind being specific about what additional things it'd be useful to see here? We're happy to pull together whatever we can

i would love to see the workflow representative, so that i can reproduce

I unfortunately cannot share the full workflow, lots of company code in there. Couple options, we're always happy to hop on a call and do some live debugging, or I could try to make a version of the workflow with a stubbed implementations that have the same inputs/outputs to see if we can reproduce that way. The inputs and outputs are generally not themselves sensitive.

@famous-flag-22960 a repro would be great. Thank you. Looking forward to figuring this one out.

@hallowed-camera-82098 / @famous-flag-22960 flyte single binary (and each individual component) exposes a golang pprof endpoint on port 10254 by default. Using this we can see exactly where in the binary we're storing tons of data. You can use:

wget -O heap.out <http://localhost:10254/debug/pprof/heap>

if the flyte binary is at

localhost:10254

to retrieve a dump of the heap, and then something like:

go tool pprof -no_browser -http :8080 heap.out

to start a webserver displaying the results which should show something like the image below. It would be great it we could even get a dump of the heap and would be happy to look through the issues there.

There’s a diff of the heap growing posted earlier in this thread