Before the move to the monorepo, each commit to on...
# ask-the-community
b
Before the move to the monorepo, each commit to one of the single repos (e.g.
flytepropeller
) did create a new release there and publish an image. Does the same still happen in the monorepo? Asking because I would like to try a new change to
flytepropeller
(this one). I’ve checked the github workflows, and while this job suggests an image would be built, a
docker pull <http://ghcr.io/flyteorg/flytepropeller:047924d3812d7d0fa6dc7904c279094a13a9f95d|ghcr.io/flyteorg/flytepropeller:047924d3812d7d0fa6dc7904c279094a13a9f95d>
results in a
Error response from daemon: manifest unknown
. I’m also seeing a
WARNING: No output specified with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
at the end of the job
d
cc @Eduardo Apolinario (eapolinario)
e
no, we no longer build a images on merges to master, only on releases (which are human-controlled). We could go back to producing images using SHAs on merges to master. @Bernhard Stadlbauer, mind opening a gh issue to track this? Should be a relatively easy change.
b
Sure thing, issue is up here
Would there be more to it then a
--push
in the workflow file? Happy to add a PR for that then as well
e
@Bernhard Stadlbauer, sorry for the delay! A push only in cases of merges to master would suffice.