#544 Remove resource injection on the node for container task Pull request opened by ByronHsu TL;DR Remove resource injection on the node for container task Type ☑︎ Bug Fix ☐ Feature ☐ Plugin Are all requirements met? ☑︎ Code completed ☑︎ Smoke tested ☑︎ Unit tests added ☑︎ Code documentation added ☑︎ Any pending items have an associated Issue Complete description How did you fix the bug, make the feature etc. Link to any design docs etc In BuildRawContainer, we do not inject the container resource from the task template. Instead, we inject the resource from parameters.TaskExecMetadata.GetOverrides().GetResources(). This is because for both

_with_override(resource=...

and

@task(requests=...)

, they are both inject as the node resource override in buildNodeSpec Expected behavior For the case of

@task(requests=...)

, the resource override on the node should be empty, and the resource is injected from tasktemplate at BuildRawContainer Tracking Issue flyteorg/flyte#3540 flyteorg/flytepropeller GitHub Actions: Goreleaser GitHub Actions: Build & Push Flytepropeller Image GitHub Actions: Bump Version ✅ 11 other checks have passed 11/14 successful checks