#335 Inject container resource during BuildRawContainer Pull request opened by ByronHsu TL;DR Inject container resource during BuildRawContainer Type ☑︎ Bug Fix ☐ Feature ☐ Plugin Are all requirements met? ☑︎ Code completed ☑︎ Smoke tested ☑︎ Unit tests added ☑︎ Code documentation added ☑︎ Any pending items have an associated Issue Complete description How did you fix the bug, make the feature etc. Link to any design docs etc Describe the bug Note: This bug does not affect the behavior of Flyte, but the logic contains a flaw. In BuildRawContainer, we do not inject the container resource from the task template. Instead, we inject the resource from parameters.TaskExecMetadata.GetOverrides().GetResources(). This is because for both

_with_override(resource=...

and

@task(requests=...)

, they are both inject as the node resource override in buildNodeSpec Expected behavior For the case of

@task(requests=...)

, the resource override on the node should be empty, and the resource is injected from tasktemplate at BuildRawContainer Tracking Issue flyteorg/flyte#3540 flyteorg/flyteplugins Codecov: 33.33% of diff hit (target 62.75%) Codecov: 62.65% (-0.11%) compared to 60d345d ✅ 4 other checks have passed 4/6 successful checks