Hi all, has anyone else run into issue when trying to render workflows that go past a depth of 5 in ...

square-boots-41503

03/10/2023, 5:23 PM

Hi all, has anyone else run into issue when trying to render workflows that go past a depth of 5 in the UI? The UI can’t seem to render anything past the 5th nested node. Attached is a screenshot of what I’m seeing and the code for how to reproduce it. I would expect to see

wf_6

and

wf_7

also rendered in the UI bug I don’t see in the “Nodes” tab nor the “Timeline” tab. The “Graph” tab only shows a single node which is another problem but I believe people are aware and working on that issue.

Copy code

@dynamic
def wf_1(n: int) -> int:
    return wf_2(n=n+1)

@dynamic
def wf_2(n: int) -> int:
    return wf_3(n=n+1)

@dynamic
def wf_3(n: int) -> int:
    return wf_4(n=n+1)

@dynamic
def wf_4(n: int) -> int:
    return wf_5(n=n+1)

@dynamic
def wf_5(n: int) -> int:
    return wf_6(n=n+1)

@dynamic
def wf_6(n: int) -> int:
    return wf_7(n=n+1)

@dynamic
def wf_7(n: int) -> int:
    return n+1

@workflow
def run_wf(n: int) -> int:
    return wf_1(n=n)

broad-monitor-993

03/10/2023, 5:25 PM

@late-eye-50215 are you familiar with this UI bug? basically dynamic workflows can go 5 levels deep

late-eye-50215

03/10/2023, 10:01 PM

Hey @square-boots-41503 - sorry about that; this is definitely not supposed to happen. Could I ask what version of UI you're running on?

late-eye-50215

03/10/2023, 10:02 PM

Asking because

1.4

release included a fix that should have resolved this issue - definitely possible its still broken but letting us know which version of

flyteconsole

is running will help us figure this out 👍

square-boots-41503

03/10/2023, 10:07 PM

I’m on 1.4.1! Admin version is 1.1.70 if that matters.

late-eye-50215

03/11/2023, 2:33 AM

Okay strange. I'll cut an issue and we'll investigate this and keep you updated 👍

square-boots-41503

03/12/2023, 3:44 AM

thanks Jason!

late-eye-50215

03/13/2023, 5:09 PM

Hey @square-boots-41503 - I think I know what happened; we had a known issue with 1.4 that was fixed in the latest flyte release. Can you try pulling that down? https://github.com/flyteorg/flyteconsole/releases/tag/v1.4.3

square-boots-41503

03/13/2023, 5:23 PM

sounds good. I’ll try that out.

square-boots-41503

03/16/2023, 9:34 PM

That fixed the issue. Thanks @late-eye-50215! On a slightly related but different issue, we found another niche case where the UI breaks when rendering nodes. The reproduction case seems to if

@workflow

is called recursively like in the following code.

Copy code

@dynamic
def wf_recurse(n: int) -> int:
    print(f'Calling wf_recurse with {n=}')
    return wf_recurse_conditional(n=n-1)

@dynamic
def return_n(n: int) -> int:
    return n

@workflow
def wf_recurse_conditional(n: int) -> int:
    return (
        conditional("cond")
        .if_(n == 0)
        .then(return_n(n=n))
        .else_()
        .then(
            wf_recurse(
                n=n
            )
        )
     )

@workflow
def run_wf(n: int) -> int:
    return wf_recurse(n=n

I attached a screen recording of the UI error.

Screen Recording 2023-03-16 at 4.20.08 PM.mov

square-boots-41503

03/16/2023, 9:36 PM

It's fine if we convert the

@workflow

to be a

@dynamic

function but that has a different issue where

.with_overrides(name=??)

doesn't work but I believe that's being tracked in a separate issue.

late-eye-50215

03/16/2023, 10:25 PM

Okay great. And yeah, that second issue will fix the name override 👍

late-eye-50215

03/16/2023, 10:28 PM

Or, wait, rather it will be fixed by this issue (dupe) https://github.com/flyteorg/flyte/issues/3470

👍 1

151 Views

Open in Slack

Previous Next

Flyte

Flyte enables production-grade orchestration for machine learning workflows and data processing created to accelerate local workflows to production.