#310 Return nil if ResourceMeta is nil when deleting the node Pull request opened by pingsutw Fixes flyteorg/flyte#3281 TL;DR Transition to failed state if the task isn't created. otherwise, the task will run forever. 1 round (phase:

PhaseNotStarted

) • Webapi plugin try to allocate token 2 round (state:

PhaseAllocationTokenAcquired

, phase:

queued

): • Plugin fail to create a task, and will not update the task state. The state is

PhaseAllocationTokenAcquired

in this round • Task handler send the task event (queued) to admin • However we transition the phase from queued to running here • And we will record the node event (running) in the node executor 3 round (state:

PhaseAllocationTokenAcquired

, phase:

running

): • Will try to create a task, and fail again • In the screenshot below, you can see the node phase is

running

, but the task state is

queued

4+ round • Repeat 3 round Update: we should just return nil if task metadata is nil Type ☑︎ Bug Fix ☐ Feature ☐ Plugin Are all requirements met? ☑︎ Code completed ☑︎ Smoke tested ☑︎ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Complete description Before After Tracking Issue flyteorg/flyte#3281 It's related to this issue propeller panic because taskCtx.ResourceMeta() is nil. However, it should never happen. it was happening because we tried to abort the task that doesn't exist. Follow-up issue NA flyteorg/flyteplugins Codecov: 62.87% (-0.15%) compared to 36c0b41 Codecov: 0.00% of diff hit (target 63.02%) ✅ 4 other checks have passed 4/6 successful checks