<@U03N8LN2SHX> didn’t finish but started looking a...
# flyte-supportt
thankful-minister-83577
03/01/2023, 4:14 PM
@quaint-diamond-37493 didn’t finish but started looking at your pr yesterday.
thankful-minister-83577
03/01/2023, 4:14 PM
still haven’t gotten it to work however
thankful-minister-83577
03/01/2023, 4:14 PM
i don’t have access to your fork, so i pulled that commit, pushed it to main
thankful-minister-83577
03/01/2023, 4:14 PM
and these are the changes i have so far https://github.com/flyteorg/flytekit/pull/1528/files
thankful-minister-83577
03/01/2023, 4:15 PM
flyteidl will also need to be bumped, i installed that manually
thankful-minister-83577
03/01/2023, 4:15 PM
i bundled the backend changes however into
Copy code
flytectl demo start --image <http://ghcr.io/flyteorg/flyte-sandbox-bundled:sha-7416ccdfdad59d91550b050c662b9bf4b2ea1f3b|ghcr.io/flyteorg/flyte-sandbox-bundled:sha-7416ccdfdad59d91550b050c662b9bf4b2ea1f3b>thankful-minister-83577
03/01/2023, 4:16 PM
basically assuming all the backend stuff works you should be able to test with that too
thankful-minister-83577
03/01/2023, 4:16 PM
that image was generated by this pr
thankful-minister-83577
03/01/2023, 4:16 PM
cc @hallowed-mouse-14616
thankful-minister-83577
03/01/2023, 4:17 PM
dan and i will spend a bit more time on it today, try to get some examples working
thankful-minister-83577
03/01/2023, 4:17 PM
after that maybe you could merge changes into your pr and write some tests?
q
quaint-diamond-37493
03/01/2023, 4:35 PM👍
quaint-diamond-37493
03/01/2023, 4:39 PMah, right... misread the flyeidl changes, the data loading config is added to K8sPod, not PodTemplate... will incorporate your changes and fix that part.
This was done blindly so far, as I didn't have any of the backend changes
quaint-diamond-37493
03/01/2023, 4:44 PMthx, pushed some minor cleanup, can continue tomorrow if you can give me some hints on how to test with latest backend stuff
t
thankful-minister-83577
03/01/2023, 5:02 PM
yeah testing should be pretty easy, assuming all the backend changes are correct (and we have no reason to believe they’re not).
thankful-minister-83577
03/01/2023, 5:02 PM
just teardown any existing sandbox you have
thankful-minister-83577
03/01/2023, 5:03 PM
run the flytectl command
thankful-minister-83577
03/01/2023, 5:03 PM
and then just register an example
Copy code
pyflyte --config ~/.flyte/config-sandbox.yaml register --version fr6 core/ress.pythankful-minister-83577
03/01/2023, 5:04 PM
inside that file is
thankful-minister-83577
03/01/2023, 5:04 PM
Untitled
thankful-minister-83577
03/01/2023, 11:22 PM
hey @quaint-diamond-37493 actually there was something we needed to change on the backend - we’ve confirmed it works now though. could you restart your demo cluster please with
Copy code
flytectl demo start --image <http://ghcr.io/flyteorg/flyte-sandbox-bundled:sha-e3703333bbef6153f5ec15d3c0c6500009c41bdf|ghcr.io/flyteorg/flyte-sandbox-bundled:sha-e3703333bbef6153f5ec15d3c0c6500009c41bdf>thankful-minister-83577
03/01/2023, 11:22 PM
with that up you should be able to launch that example at least (though it won’t actually run)
q
quaint-diamond-37493
03/02/2023, 7:19 PMsorry, I've putting out fires the whole day and didn't have time for flyte
quaint-diamond-37493
03/02/2023, 7:30 PMwhat's the status on https://github.com/flyteorg/flyteidl/pull/368 and https://github.com/flyteorg/flyteplugins/pull/325 ?
To add unit tests this will need to be added/bumped in flytekit...
Don't really know how to add tests without that to be honest...
150 Views