didn t finish but started looking at your pr

Question

< Felix Ruess> didn t finish but started looking at your pr yesterday

Yee · Answer

still haven t gotten it to work however

Yee · Answer

i don t have access to your fork so i pulled that commit pushed it to main

Yee · Answer

and these are the changes i have so far <https github com flyteorg flytekit pull 1528 files>

Yee · Answer

flyteidl will also need to be bumped i installed that manually

Yee · Answer

i bundled the backend changes however into ```flytectl demo start image <http ghcr io flyteorg flyte sandbox bundled sha 7416ccdfdad59d91550b050c662b9bf4b2ea1f3b|ghcr io flyteorg flyte sandbox bundled sha 7416ccdfdad59d91550b050c662b9bf4b2ea1f3b>```

Yee · Answer

basically assuming all the backend stuff works you should be able to test with that too

Yee · Answer

that image was generated by <https github com flyteorg flyte pull 3382|this pr>

Yee · Answer

cc < Dan Rammer hamersaw >

Yee · Answer

dan and i will spend a bit more time on it today try to get some examples working

Yee · Answer

after that maybe you could merge changes into your pr and write some tests

Felix Ruess · Answer

+1

Felix Ruess · Answer

ah right misread the flyeidl changes the data loading config is added to K8sPod not PodTemplate will incorporate your changes and fix that part This was done blindly so far as I didn t have any of the backend changes

Felix Ruess · Answer

thx pushed some minor cleanup can continue tomorrow if you can give me some hints on how to test with latest backend stuff

Yee · Answer

yeah testing should be pretty easy assuming all the backend changes are correct and we have no reason to believe they re not

Yee · Answer

just teardown any existing sandbox you have

Yee · Answer

run the flytectl command

Yee · Answer

and then just register an example ```pyflyte config ~ flyte config sandbox yaml register version fr6 core ress py```

Yee · Answer

inside that file is

Yee · Answer

Untitled

Yee · Answer

hey < Felix Ruess> actually there was something we needed to change on the backend we ve confirmed it works now though could you restart your demo cluster please with ```flytectl demo start image ```

Yee · Answer

with that up you should be able to launch that example at least though it won t actually run

Felix Ruess · Answer

sorry I ve putting out fires the whole day and didn t have time for flyte

Felix Ruess · Answer

what s the status on and To add unit tests this will need to be added bumped in flytekit Don t really know how to add tests without that to be honest