<@U03N8LN2SHX> didn’t finish but started looking a...
# ask-the-community
y
@Felix Ruess didn’t finish but started looking at your pr yesterday.
still haven’t gotten it to work however
i don’t have access to your fork, so i pulled that commit, pushed it to main
and these are the changes i have so far https://github.com/flyteorg/flytekit/pull/1528/files
flyteidl will also need to be bumped, i installed that manually
i bundled the backend changes however into
Copy code
flytectl demo start --image <http://ghcr.io/flyteorg/flyte-sandbox-bundled:sha-7416ccdfdad59d91550b050c662b9bf4b2ea1f3b|ghcr.io/flyteorg/flyte-sandbox-bundled:sha-7416ccdfdad59d91550b050c662b9bf4b2ea1f3b>
basically assuming all the backend stuff works you should be able to test with that too
that image was generated by this pr
cc @Dan Rammer (hamersaw)
dan and i will spend a bit more time on it today, try to get some examples working
after that maybe you could merge changes into your pr and write some tests?
f
👍
ah, right... misread the flyeidl changes, the data loading config is added to K8sPod, not PodTemplate... will incorporate your changes and fix that part. This was done blindly so far, as I didn't have any of the backend changes
thx, pushed some minor cleanup, can continue tomorrow if you can give me some hints on how to test with latest backend stuff
y
yeah testing should be pretty easy, assuming all the backend changes are correct (and we have no reason to believe they’re not).
just teardown any existing sandbox you have
run the flytectl command
and then just register an example
Copy code
pyflyte --config ~/.flyte/config-sandbox.yaml register --version fr6 core/ress.py
inside that file is
Untitled
hey @Felix Ruess actually there was something we needed to change on the backend - we’ve confirmed it works now though. could you restart your demo cluster please with
Copy code
flytectl demo start --image <http://ghcr.io/flyteorg/flyte-sandbox-bundled:sha-e3703333bbef6153f5ec15d3c0c6500009c41bdf|ghcr.io/flyteorg/flyte-sandbox-bundled:sha-e3703333bbef6153f5ec15d3c0c6500009c41bdf>
with that up you should be able to launch that example at least (though it won’t actually run)
f
sorry, I've putting out fires the whole day and didn't have time for flyte
what's the status on https://github.com/flyteorg/flyteidl/pull/368 and https://github.com/flyteorg/flyteplugins/pull/325 ? To add unit tests this will need to be added/bumped in flytekit... Don't really know how to add tests without that to be honest...