<#694 [WIP] fix: dynamic node names in graph view>...
# flyte-github
a
#694 [WIP] fix: dynamic node names in graph view Pull request opened by 4nalog flyteorg/flyte#3370 TL;DR This PR fixes bug where display names for nodes in the graph view for the workflow are not correctly overridden when an override is provided using the
with_overrides
chain method. See https://flyte-org.slack.com/archives/CP2HDHKE1/p1677082683989289 for complete context. How to reproduce https://localhost.development.uniondemo.run:3000/console/projects/flytesnacks/domains/development/executions/fffe8fffa9cdc403a909?duration=all How to fix • implements logic to get
nodeExecution
when rendering a given node to fetch the displayId. Falls back to
node text => execution.node.id
if no
displayId
is found Type ☑︎ Bug Fix ☐ Feature ☐ Plugin Are all requirements met? ☑︎ Code completed ☑︎ Smoke tested ☐ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Complete description • The display name of a specific node in a worflow could be overriden by making a chained called a
.with_overrides(name=foo)
method when defining the workflow in the python file. This lets users create nodes with dynamic names. For a specific use-case, see https://flyte-org.slack.com/archives/CP2HDHKE1/p1677082683989289 • The value of the node names are correctly overridden when in the list nodes view but fail in the graph view. • The PR takes logic used in the
nodeExecutionColumns.tsx
file to implement similar logic to fetch
displayId
of a node by fetching its execution and if not fallbacks to the
text
Tracking Issue Fixes flyteorg/flyte#3370 flyteorg/flyteconsole GitHub Actions: Build & Push FlyteConsole Image GitHub Actions: Get Release Tag GitHub Actions: Generate Release GitHub Actions: unit_tests_with_coverage 5 other checks have passed 5/9 successful checks