<#531 Remove duplicate logic of resolveSecurityCtx...
# flyte-github
a
#531 Remove duplicate logic of resolveSecurityCtx in execution_manager Pull request opened by ByronHsu TL;DR
resolvedSecurity
falls back to
executionConfigSecurityCtx
if exists in
func resolveSecurityCtx
(here). We don't need duplicated logic here. Type ☑︎ Refactor Are all requirements met? ☑︎ Code completed ☐ Smoke tested ☑︎ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Test ``` Makefile33 warning: overriding recipe for target `k8s_integration_execute' boilerplate/flyte/end2end/Makefile12 warning: ignoring old recipe for target `k8s_integration_execute' go test -cover ./... -race ok github.com/flyteorg/flyteadmin/auth 1.475s coverage: 34.6% of statements ok github.com/flyteorg/flyteadmin/auth/authzserver 17.421s coverage: 60.6% of statements ok github.com/flyteorg/flyteadmin/auth/config 0.358s coverage: 63.6% of statements ? github.com/flyteorg/flyteadmin/auth/interfaces [no test files] ? github.com/flyteorg/flyteadmin/auth/interfaces/mocks [no test files] ? github.com/flyteorg/flyteadmin/cmd [no test files] ? github.com/flyteorg/flyteadmin/cmd/entrypoints [no test files] ? github.com/flyteorg/flyteadmin/cmd/scheduler [no test files] ? github.com/flyteorg/flyteadmin/cmd/scheduler/entrypoints [no test files] ok github.com/flyteorg/flyteadmin/dataproxy 0.317s coverage: 61.8% of statements ok github.com/flyteorg/flyteadmin/pkg/async 0.245s coverage: 100.0% of statements ok github.com/flyteorg/flyteadmin/pkg/async/cloudevent 0.214s coverage: 78.6% of statements ok github.com/flyteorg/flyteadmin/pkg/async/cloudevent/implementations 0.241s coverage: 83.3% of statements ? github.com/flyteorg/flyteadmin/pkg/async/cloudevent/interfaces [no test files] ? github.com/flyteorg/flyteadmin/pkg/async/cloudevent/mocks [no test files] ok github.com/flyteorg/flyteadmin/pkg/async/events/implementations 0.218s coverage: 45.0% of statements ? github.com/flyteorg/flyteadmin/pkg/async/events/interfaces [no test files] ? github.com/flyteorg/flyteadmin/pkg/async/events/mocks [no test files] ok github.com/flyteorg/flyteadmin/pkg/async/notifications 0.229s coverage: 18.9% of statements ok github.com/flyteorg/flyteadmin/pkg/async/notifications/implementations 0.295s coverage: 72.9% of statements ? github.com/flyteorg/flyteadmin/pkg/async/notifications/interfaces [no test files] ? github.com/flyteorg/flyteadmin/pkg/async/notifications/mocks [no test files] ? github.com/flyteorg/flyteadmin/pkg/async/schedule [no test files] ok github.com/flyteorg/flyteadmin/pkg/async/schedule/aws 0.363s coverage: 66.7% of statements ? github.com/flyteorg/flyteadmin/pkg/async/schedule/aws/interfaces [no test files] ? github.com/flyteorg/flyteadmin/pkg/async/schedule/aws/mocks [no test files] ? github.com/flyteorg/flyteadmin/pkg/async/schedule/interfaces [no test files] ? github.com/flyteorg/flyteadmin/pkg/async/schedule/mocks [no test files] ? github.com/flyteorg/flyteadmin/pkg/async/schedule/noop [no test files] ok github.com/flyteorg/flyteadmin/pkg/clusterresource 0.528s coverage: 33.4% of statements ok github.com/flyteorg/flyteadmin/pkg/clusterresource/impl 0.230s coverage: 89.7% of statements ? github.com/flyteorg/flyteadmin/pkg/clusterresource/interfaces [no test files] ? github.com/flyteorg/flyteadmin/pkg/clusterresource/mocks [no test files] ok github.com/flyteorg/flyteadmin/pkg/common 0.370s coverage: 75.3% of statements ? github.com/flyteorg/flyteadmin/pkg/common/mocks [no test files] ? github.com/flyteorg/flyteadmin/pkg/common/testutils [no test files] ok github.com/flyteorg/flyteadmin/pkg/config 0.158s coverage: 60.0% of statements ? github.com/flyteorg/flyteadmin/pkg/data [no test files] ok github.com/flyteorg/flyteadmin/pkg/data/implementations 0.138s coverage: 62.0% of statements ? github.com/flyteorg/flyteadmin/pkg/data/interfaces [no test files] ? github.com/flyteorg/flyteadmin/pkg/data/mocks [no test files] ok github.com/flyteorg/flyteadmin/pkg/errors 0.192s coverage: 56.1% of statements ? github.com/flyteorg/flyteadmin/pkg/executioncluster [no test files] ok github.com/flyteorg/flyteadmin/pkg/executioncluster/impl 0.711s coverage: 59.0% of statements ? github.com/flyteorg/flyteadmin/pkg/executioncluster/interfaces [no test files] ? github.com/flyteorg/flyteadmin/pkg/executioncluster/mocks [no test files] ? github.com/flyteorg/flyteadmin/pkg/flytek8s [no test files] ok <http://github.com/flyteorg/flyteadmin/pkg/manager/impl|github.com/flyteorg… flyteorg/flyteadmin GitHub Actions: Build & Push Flytescheduler Image GitHub Actions: Goreleaser GitHub Actions: Build & Push Flyteadmin Image GitHub Actions: Bump Version Codecov: 60.09% (-0.08%) compared to fb003b7 9 other checks have passed 9/14 successful checks