<#196 Do not delegate class loading to parent for ...
# flyte-github
a
#196 Do not delegate class loading to parent for some classes Pull request opened by honnix TL;DR Only load certain classes from child. Type ☑︎ Bug Fix ☐ Feature ☐ Plugin Are all requirements met? ☑︎ Code completed ☑︎ Smoke tested ☑︎ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Complete description Unfortunately #145 did not fully fix flyteorg/flyte#3147 because it only fixed resource, not class. This PR will skip delegating to parent for class load as well. This is what slf4j <2.0.x does:
Copy code
if (!isAndroid()) {
                staticLoggerBinderPathSet = findPossibleStaticLoggerBinderPathSet();
                reportMultipleBindingAmbiguity(staticLoggerBinderPathSet);
            }
            // the next line does the binding
            StaticLoggerBinder.getSingleton();
findPossibleStaticLoggerBinderPathSet
does the resource load so even we prevent delegation to parent at that point,
StaticLoggerBinder.getSingleton()
will still delegate to parent, without this PR. Tracking Issue _Remove the '_fixes_' keyword if there will be multiple PRs to fix the linked issue_ fixes flyteorg/flyte#3147 Follow-up issue NA flyteorg/flytekit-java All checks have passed 3/3 successful checks