acoustic-carpenter-78188
02/14/2023, 10:49 PMApproveCondition
. ApprovedCondition only accepts true
(boolean) as an input and should be presented to the user as displaying the incoming input and the simply allowing them to click on 'resume' in the Signal Form. Currently, these nodes (correctly) show the incoming inputs but the resume button is greyed out.
Note: the shape of ApprovedCondition gate nodes is a little different in the CompiledWorkflowClosure
-- look for gateNode
and approve
. Here is an example from core.control_flow.human_in_the_loop.mainwf
// Example of ApprovedCondition
{
"gateNode": {
"approve": {
"signalId": "approvalfory"
}
}
}
IDL: Link to ApprovedCondition in IDL
Goal: What should the final outcome look like, ideally?
Acceptance Criteria:
• Renders incoming inputs (this currently works just make sure the fix doesn't break it)
• Allows user to click "resume" (this is currently greyed out)
• Sends true
as value
Propose: Link/Inline OR Additional context
This was ported over from this other board: unionai/cloud#1518
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyteacoustic-carpenter-78188
03/09/2023, 9:22 PMacoustic-carpenter-78188
03/10/2023, 8:07 PM