<#387 refactor: remove redundant YAML packages> Pu...
# flyte-github
a
#387 refactor: remove redundant YAML packages Pull request opened by Juneezee TL;DR Remove redundant YAML packages:
<http://github.com/ghodss/yaml|github.com/ghodss/yaml>
and
<http://gopkg.in/yaml.v2|gopkg.in/yaml.v2>
Type ☐ Bug Fix ☐ Feature ☐ Plugin Are all requirements met? ☑︎ Code completed ☐ Smoke tested ☐ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Complete description Currently four YAML packages are used: 1.
<http://github.com/ghodss/yaml|github.com/ghodss/yaml>
2.
<http://gopkg.in/yaml.v2|gopkg.in/yaml.v2>
3.
<http://gopkg.in/yaml.v3|gopkg.in/yaml.v3>
4.
<http://sigs.k8s.io/yaml|sigs.k8s.io/yaml>
We can keep only two of them: 1.
<http://gopkg.in/yaml.v3|gopkg.in/yaml.v3>
2.
<http://sigs.k8s.io/yaml|sigs.k8s.io/yaml>
The package
<http://github.com/ghodss/yaml|github.com/ghodss/yaml>
is no longer actively maintained. See discussion in ghodss/yaml#80 and ghodss/yaml#75.
<http://sigs.k8s.io/yaml|sigs.k8s.io/yaml>
is a permanent fork of
ghodss/yaml
and is actively maintained by Kubernetes SIG, also widely used in K8s projects. We are only using
<http://gopkg.in/yaml.v2|gopkg.in/yaml.v2>
in
cmd/config/subcommand/project/project_config.go
. Switching to
<http://gopkg.in/yaml.v3|gopkg.in/yaml.v3>
doesn't introduce breaking change here. Tracking Issue Follow-up issue NA flyteorg/flytectl GitHub Actions: Generate documentation GitHub Actions: Goreleaser GitHub Actions: Bump Version 9 other checks have passed 9/12 successful checks