acoustic-carpenter-78188
01/30/2023, 1:27 PMExecutionNodeViews page
• Moved childGroups fetch to onToggle in Table and Timeline components - requests trigger when user clicked on expander
• Moved map tasks fetch to details page to back fill one-off nodeExecutions data, and to ReactFlowGraphComponent to batch them for all known nodeExecutions, so the graph is rendered properly (this will slow down the graph tab, but based on user's feedback, it's ok, if graph tab takes some time to load).
Known issues
☐ some unit tests are broken
☑︎ add childGroups fetch in graph on node click
☐ fix rerender of graph on childGroups fetch
☑︎ fix compiledWorkflowClosure to check for is_dynamic field (available in node execution's metadata) instead of pulling multiple requests on repeat
☐ test filters in Table tab
☐ display parent node as nested in graph to indicate it has children
Follow-up issue
NA
Test workflows
• normal core.control_flow.subworkflows.parent_wf
• dynamic <http://core.control_flow.dynamics.wf|core.control_flow.dynamics.wf>
• nested parent core.control_flow.subworkflows.nested_parent_wf
• map task <http://flyte.workflows.example_map_task.wf|flyte.workflows.example_map_task.wf>
flyteorg/flyteconsole
✅ All checks have passed
2/2 successful checksacoustic-carpenter-78188
01/30/2023, 1:27 PM