melodic-magician-71351
01/30/2023, 11:59 AMContainerTask
with a toleration or affinity? It looks like I may have define a custom Task
that overrides the pod spec construction method right now?melodic-magician-71351
01/30/2023, 2:01 PMContainerTask
forces task_config=None
in its super().__init__
call, which prevents callers from forwarding a task_config
up to PythonTask
broad-monitor-993
01/30/2023, 3:25 PMsuper().__init__
, unless Iām missing something @high-accountant-32689 @freezing-airport-6809?hallowed-mouse-14616
01/30/2023, 3:29 PMt = ContainerTask(
name="foo",
image="bar:latest",
command=[
"echo",
"hello",
"{{.inputs.b}}",
"/var/outputs",
],
pod_template=PodTemplate(
spec=PodSpec(
tolerations={...}
)
)
)
This have been pretty high priority for us, because many users are interested. We're planning on having a beta release out later this week.melodic-magician-71351
01/30/2023, 3:32 PMmelodic-magician-71351
01/30/2023, 3:33 PMhallowed-mouse-14616
01/30/2023, 3:33 PMContainerTask
. We'll have a beta out later this week - but unfortunately this support will not be a part of it. It looks like you've dove into this a little bit, would you be interested in contributed support for specifying pod_template
for ContainerTask
?hallowed-mouse-14616
01/30/2023, 3:34 PMpod_template
support. It does everything the pod plugin does, and more.melodic-magician-71351
01/30/2023, 3:35 PMhallowed-mouse-14616
01/30/2023, 3:37 PMmelodic-magician-71351
01/30/2023, 4:11 PMContainerTask
becomes basically a no-op once you have a pod template? I'm assuming the sidecar container gets injected server-side for raw-container
type tasks? because I don't see its definition anywhere in python.hallowed-mouse-14616
01/30/2023, 4:56 PMI'm assuming the sidecar container gets injected server-sideabsolutley, actually happens here
melodic-magician-71351
01/30/2023, 5:25 PMContainerTask
definition;
⦠Fail if both are defined at all.
⦠Deep merge failing on mismatch
⦠Deep merge warning/log on mismatch
My understanding of how people use PodTemplates is incomplete, but I'm assuming there are compelling reasons to have primary container definitions included (e.g. volume mounts), so I would think the 3rd option is best.quaint-diamond-37493
01/30/2023, 5:39 PMmelodic-magician-71351
01/30/2023, 5:51 PMpod_template
argument, so this would solve that issue indirectlyquaint-diamond-37493
01/30/2023, 5:51 PMquaint-diamond-37493
01/30/2023, 5:53 PMhallowed-mouse-14616
01/30/2023, 9:11 PMmelodic-magician-71351
02/01/2023, 12:01 PMmelodic-magician-71351
02/01/2023, 12:03 PMhallowed-mouse-14616
02/01/2023, 12:03 PMmelodic-magician-71351
02/01/2023, 12:05 PMhallowed-mouse-14616
02/01/2023, 12:27 PMquaint-diamond-37493
02/01/2023, 1:57 PMfreezing-airport-6809
melodic-magician-71351
02/01/2023, 3:23 PMfreezing-airport-6809
freezing-airport-6809
freezing-airport-6809