Eli Bixby
01/30/2023, 11:59 AMContainerTask
with a toleration or affinity? It looks like I may have define a custom Task
that overrides the pod spec construction method right now?ContainerTask
forces task_config=None
in its super().__init__
call, which prevents callers from forwarding a task_config
up to PythonTask
Niels Bantilan
01/30/2023, 3:25 PMsuper().__init__
, unless I’m missing something @Eduardo Apolinario (eapolinario) @Ketan (kumare3)?Dan Rammer (hamersaw)
01/30/2023, 3:29 PMt = ContainerTask(
name="foo",
image="bar:latest",
command=[
"echo",
"hello",
"{{.inputs.b}}",
"/var/outputs",
],
pod_template=PodTemplate(
spec=PodSpec(
tolerations={...}
)
)
)
This have been pretty high priority for us, because many users are interested. We're planning on having a beta release out later this week.Eli Bixby
01/30/2023, 3:32 PMDan Rammer (hamersaw)
01/30/2023, 3:33 PMContainerTask
. We'll have a beta out later this week - but unfortunately this support will not be a part of it. It looks like you've dove into this a little bit, would you be interested in contributed support for specifying pod_template
for ContainerTask
?pod_template
support. It does everything the pod plugin does, and more.Eli Bixby
01/30/2023, 3:35 PMDan Rammer (hamersaw)
01/30/2023, 3:37 PMEli Bixby
01/30/2023, 4:11 PMContainerTask
becomes basically a no-op once you have a pod template? I'm assuming the sidecar container gets injected server-side for raw-container
type tasks? because I don't see its definition anywhere in python.Dan Rammer (hamersaw)
01/30/2023, 4:56 PMI'm assuming the sidecar container gets injected server-sideabsolutley, actually happens here
Eli Bixby
01/30/2023, 5:25 PMContainerTask
definition;
◦ Fail if both are defined at all.
◦ Deep merge failing on mismatch
◦ Deep merge warning/log on mismatch
My understanding of how people use PodTemplates is incomplete, but I'm assuming there are compelling reasons to have primary container definitions included (e.g. volume mounts), so I would think the 3rd option is best.Felix Ruess
01/30/2023, 5:39 PMEli Bixby
01/30/2023, 5:51 PMpod_template
argument, so this would solve that issue indirectlyFelix Ruess
01/30/2023, 5:51 PMDan Rammer (hamersaw)
01/30/2023, 9:11 PMEli Bixby
02/01/2023, 12:01 PMDan Rammer (hamersaw)
02/01/2023, 12:03 PMEli Bixby
02/01/2023, 12:05 PMDan Rammer (hamersaw)
02/01/2023, 12:27 PMFelix Ruess
02/01/2023, 1:57 PMKetan (kumare3)
02/01/2023, 3:08 PMEli Bixby
02/01/2023, 3:23 PMKetan (kumare3)
02/01/2023, 3:26 PM