https://flyte.org logo
#ask-the-community
Title
# ask-the-community
f

Felix Ruess

01/20/2023, 11:44 AM
I have ContainerTasks without any outputs, but it still creates the copilot uploader sidecar, which then exits immediately marking the pod as not ready... Would be better if the sidecar is not even created in the first place, and there is a check for that in https://github.com/flyteorg/flyteplugins/blob/master/go/tasks/pluginmachinery/flytek8s/copilot.go#L243 Seems like a bug, any pointers to debug this further?
k

Ketan (kumare3)

01/20/2023, 2:21 PM
This is indeed a bug
Let me see the code
I guess it is an empty map?
Can you set outputs as none
If that works we can patch the empty check
f

Felix Ruess

01/20/2023, 2:26 PM
I don't set any
outputs
for
ContainerTask
and there it defaults to
None
. So maybe it gets converted somewhere else in flytekit?
k

Ketan (kumare3)

01/20/2023, 2:31 PM
Protobuf
@Felix Ruess you are right! This has changed. But we should check for none
And empty
f

Felix Ruess

01/20/2023, 3:01 PM
jep
should I create an issue for it or are you tracking it already @Ketan (kumare3)?
d

Dan Rammer (hamersaw)

01/20/2023, 5:48 PM
^ best to create an issue for it so we can track the change.
f

Felix Ruess

01/20/2023, 6:33 PM
d

Dan Rammer (hamersaw)

01/26/2023, 4:04 PM
@Felix Ruess to continue conversation here. In testing your example, yes the sidecar uploader is starting when it shouldn't. But it gracefully fails with:
Copy code
{
  "json": {},
  "level": "info",
  "msg": "Empty output interface received. Assuming void outputs. Sidecar will exit immediately.",
  "ts": "2023-01-26T16:03:36Z"
}
so this does not effect correctness right? Or are you seeing something different?
I will certainly make the flyteplugins change to not even start the uploader container, but just want to make sure I understand this.
f

Felix Ruess

01/26/2023, 4:26 PM
The task runs fine, yes. I just get stupid logs and alerts that I have unready pods.
64 Views