#514 Add include_archived flag and unit tests for it
Pull request opened by
pmahindrakar-oss on <!date^1674142716^{date_short}|2023-01-19T15:38:36Z>
Signed-off-by: pmahindrakar-oss
prafulla.mahindrakar@gmail.com
TL;DR
Current behavior of ListExecutions API is to return all executions except for archived executions if no state filter is passed
Inorder to keep the old behavior the same, adding a new includeArchived as part of the ListResourceRquest
If includeArchived is passed then no state filter override is added.
This behavior current only exists for executions and not available on launchplans, tasks and workflows as they dont support archival.
Followup with adding this behavior for other entities including saving the state
flyteorg/flyteidl#361
Type
☐ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☐ Code completed
☐ Smoke tested
☐ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
_Remove the '_fixes_' keyword if there will be multiple PRs to fix the linked issue_
fixes
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/
flyteorg/flyteadmin
GitHub Actions: Goreleaser
GitHub Actions: Build & Push Flyteadmin Image
GitHub Actions: Build & Push Flytescheduler Image
GitHub Actions: Bump Version
Codecov: 25.00% of diff hit (target 60.04%)
GitHub Actions: End2End Test / End to End tests
GitHub Actions: Lint / Run Lint
✅ 7 other checks have passed
7/14 successful checks