<#1415 Flip the settings for channel and logger> P...
# flyte-github
a
#1415 Flip the settings for channel and logger Pull request opened by wild-endeavor TL;DR Not sure why we didn't do this to begin with... doesn't this make more sense? Basically • Change the channel to be wide open, debug level. • Make the root logger warning, unless set by
FLYTE_SDK_LOGGING_LEVEL
or
FLYTE_SDK_LOGGING_LEVEL_ROOT
. • Make all child loggers warning, unless set by the relevant environment variable • Unless it's the user facing logger, in which case make it info by default. Type ☑︎ Bug Fix ☐ Feature ☐ Plugin Are all requirements met? ☑︎ Code completed ☑︎ Smoke tested ☐ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Complete description See above. I think this is cleaner. Tested locally and it seems to be more what we want. Tracking Issue No issue but flyteorg/flyte#3126 and things like it keep cropping up. flyteorg/flytekit Codecov: 0.00% of diff hit (target 69.21%) Codecov: 69.20% (-0.01%) compared to 905cabc ✅ 28 other checks have passed 28/30 successful checks