<#380 Change extra hosts> Pull request opened by <...
# flyte-github
a
#380 Change extra hosts Pull request opened by wild-endeavor TL;DR I think this used to work because the flyte binary used to run as a process inside the top level container. Now it runs in the cluster. In order for K8s to call out the the webhook service (which in the
--dev
case is running on the user's host machine), we need to pipe through the host machine's IP. This works in conjunction with flyteorg/flyte#3228. This has been tested with both the
--dev
switch and without it. Type ☑︎ Bug Fix ☐ Feature ☐ Plugin Are all requirements met? ☑︎ Code completed ☑︎ Smoke tested ☐ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Complete description The extra hosts was first added in #369. At the time the flyte binary ran as a process in the dind container. I guess at that time, K8s was able to see the dind container as 127.0.0.1, and so routing there would hit the flyte binary. Tracking Issue flyteorg/flyte#3080 flyteorg/flytectl GitHub Actions: Goreleaser GitHub Actions: Generate documentation GitHub Actions: Bump Version ✅ 9 other checks have passed 9/12 successful checks