https://flyte.org logo
j

jeev

02/15/2022, 7:06 PM
@Sören Brunk: have we considered adding liveness/readiness checks to flyteadmin in the helm chart?
tagging @Justin Tyberg
j

Justin Tyberg

02/15/2022, 7:11 PM
yes, this would be useful, in general. in GCP, the google backend health check would pick it up and use it. right now we specify a custom healthcheck, but if the health endpoint changes, we wouldn’t know it.
Copy code
apiVersion: <http://cloud.google.com/v1|cloud.google.com/v1>
kind: BackendConfig
metadata:
  name: bec-flyteadmin
  namespace: flyte
spec:
  healthCheck:
    type: HTTP
    requestPath: /healthcheck
  iap:
    enabled: true
    oauthclientCredentials:
      secretName: oauth-secret
s

Sören Brunk

02/15/2022, 7:20 PM
Agreed, we definitively should add them in the chart!
👍 1
4 Views