Thread
#flyte-deployment
    j

    jeev

    7 months ago
    @Sören Brunk: have we considered adding liveness/readiness checks to flyteadmin in the helm chart?
    tagging @Justin Tyberg
    Justin Tyberg

    Justin Tyberg

    7 months ago
    yes, this would be useful, in general. in GCP, the google backend health check would pick it up and use it. right now we specify a custom healthcheck, but if the health endpoint changes, we wouldn’t know it.
    apiVersion: <http://cloud.google.com/v1|cloud.google.com/v1>
    kind: BackendConfig
    metadata:
      name: bec-flyteadmin
      namespace: flyte
    spec:
      healthCheck:
        type: HTTP
        requestPath: /healthcheck
      iap:
        enabled: true
        oauthclientCredentials:
          secretName: oauth-secret
    s

    Sören Brunk

    7 months ago
    Agreed, we definitively should add them in the chart!