https://flyte.org logo
#flytekit
Title
# flytekit
k

Kelsey Messer

01/18/2022, 8:23 PM
hello 👋 I noticed today that the flyte UI is displaying the incorrect node path name for one of my sub-workflows. in my screenshot you can see the top red box and bottom red box have the same path name. the top one is mislabeled but the bottom one is correct. we're using
flytekit==0.24.0
cc @Dylan Wilder
y

Yee

01/18/2022, 8:29 PM
do you know what the top one should read?
can you copy/paste the signatures of your workflow/subwf functions?
cc @Jason Porter in case this ends up being something in the UI.
have you seen this before
k

Kelsey Messer

01/18/2022, 9:14 PM
the top one should read
onemodel.models.label_market_share._flyte.label_market_share_standalone
and its signature is
Copy code
@workflow
def label_market_share_standalone(
    shared_params: dict,
    specific_model_params: typing.Dict[str, pd.DataFrame],
) -> typing.Tuple[Schema, Schema]:
the signature for the bottom one is
Copy code
@workflow
def msr_standalone(
    shared_params: dict,
    specific_model_params: typing.Dict[str, pd.DataFrame],
) -> Schema:
k

katrina

01/18/2022, 9:17 PM
cc @Jason Porter
k

Kelsey Messer

01/18/2022, 9:24 PM
I just noticed more errors in the screenshot... the
label-market-share-forecast
node in the first red box should read
onemodel.models.label_market_share._flyte.label_market_share_task
as its path (and it's a python task, not a sub-workflow). its signature is
Copy code
@task(
    requests=Resources(mem="1Gi", cpu="250m"),
    limits=Resources(mem="2Gi", cpu="1"),
)
def label_market_share_task(
    shared_params: dict,
    parameters: typing.Dict[str, pd.DataFrame],
) -> Schema:
similarly in the bottom red box the
msr-forecast
should read
onemodel.models.msr._flyte.msr_task
as its path (and it's a python task, not a sub-workflow). its signature is
Copy code
@task(
    cache=True,
    cache_version=environ["VERSION"],
    requests=Resources(mem="1Gi", cpu="250m"),
    limits=Resources(mem="2Gi", cpu="1"),
)
def msr_task(
    shared_params: dict,
    parameters: typing.Dict[str, pd.DataFrame],
) -> Schema:
j

Jason Porter

01/18/2022, 9:26 PM
Hey @Kelsey Messer - what version of flyteconsole are you running? I don't know if it's what's causing the issue here but I know there was a bug that expressed the same way that we fixed around v0.31?
k

Kelsey Messer

01/18/2022, 9:27 PM
@Dylan Wilder do you know the flyteconsole version? not sure where to find that
.
j

Jason Porter

01/18/2022, 9:30 PM
Is there a little "i" icon in the top right? If there is that will show you which version you're running; if not then that is likely the problem because it means you have an older version (the "version display" release preceded the fix for the task-name mapping)
k

Kelsey Messer

01/18/2022, 9:30 PM
ah ok. we're using 0.31.4
j

Jason Porter

01/18/2022, 9:31 PM
Hmmm
okay let me look into that.
@Nastya Rusina
y

Yee

01/18/2022, 9:38 PM
@Kelsey Messer can you also post in here the workflow definition.
there’s a good chance this is a flytekit error
Copy code
<http://localhost:30081/api/v1/workflows/flytesnacks/development/core.control_flow.subworkflows.nested_parent_wf/98756d945109acf6e08a022563596d22b0150ee7>
something like that
for the top level workflow… feel free to dm it if it’s at all sensitive
👍 1
the original screenshot… if you scroll up, the first workflow that produces the
n3
node, is it
label-market-share-forecast
?
can you just scroll up a bit and re-post? just want to see the parent of the first n3
k

Kelsey Messer

01/18/2022, 10:34 PM
message has been deleted
y

Yee

01/18/2022, 10:39 PM
should we hop on a call?
@Jason Porter or @Nastya Rusina do you have time?
n

Nastya Rusina

01/18/2022, 10:54 PM
@Yee I'm out of laptop now, will be able to look at it near 4pm
y

Yee

01/18/2022, 10:55 PM
all good thanks. just want to make sure we’re on the same page.
kelsey do you have time now to chat? or are you about done for the day?
just want to make sure i’m understanding the issue correctly.
k

Kelsey Messer

01/18/2022, 10:58 PM
I won't have time today but I'm free tomorrow noon-3pm EST if you want to chat then
y

Yee

01/18/2022, 11:00 PM
sounds good
s

Sören Brunk

01/19/2022, 7:30 AM
This look similar to what I’ve seen recently. https://flyte-org.slack.com/archives/CTJJLM8BY/p1639739277022300
y

Yee

01/19/2022, 7:00 PM
just fyi we are still investigating this
we’ve been able to repro this on our end - will investigate to see where the issue is coming from
hey @Jason Porter - did we ever figure this out?
n

Nastya Rusina

01/27/2022, 1:14 AM
We are still working on it, it’s a bit of a tricky one 🙂 I’m switching to it tomorrow - while Jason is out.
y

Yee

01/27/2022, 1:15 AM
oh i forgot he was out… all good thank you!
n

Nastya Rusina

01/31/2022, 11:00 PM
New issue to track this work was created https://github.com/flyteorg/flyte/issues/2117 . It is currently actively in progress. We will update the thread when fix would be published. Thank you a lot for bringing it up and being patient with us 🙂
🙏 1
k

Ketan (kumare3)

02/01/2022, 11:59 PM
@Sören Brunk / @Kelsey Messer for you guys to know, this is only a visualization bug.
🙏 2
n

Nastya Rusina

02/11/2022, 12:52 AM
@Kelsey Messer The partial fix for this visualization issue was just merged to flyte-console. Full fix will require some infrastructure changes, so we can not yet provide expected timeline for the fix. This issue has been resolved in version 0.42.1 🎉 The release is available on GitHub release
🎉 1
🙂 2
k

Kelsey Messer

02/11/2022, 2:08 PM
thank you!
24 Views