#1400 wip - Delete model files Pull request opened by eapolinario Signed-off-by: Eduardo Apolinario eapolinario@users.noreply.github.com TL;DR Remove all mentions to model files Type ☐ Bug Fix ☑︎ Feature ☐ Plugin Are all requirements met? ☐ Code completed ☐ Smoke tested ☐ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Complete description Beware: 1. Not all models are removed, so far I had to bring back

common.py

,

array_job.py

,

filters.py

, and

schedule.py

, either because there is no equivalent protobuf messages (like the objects built in

filters.py

) or because there's adhoc logic in the model files that was not straightforward to bring back (for example, in some cases we were inheriting from the model files, but now that we're moving to protobuf messages, inheriting from protobuf messages is not allowed) 2. for

oneof

fields, use

WhichOneof("field")

to check which field is set (read https://developers.google.com/protocol-buffers/docs/reference/python-generated#oneof for more details). 3. to check if a field is set, use

HasField("field")

4. use

ClearField

to set a singular field to null. 5. remote is a mess. We also do not have great test coverage there, so proceed with caution 6. No positional arguments allowed in protobuf stub constructors. 7. Enums are a little weird. For example, look at the generated code for the BlobDimensionality enum. We can refer to each value using

BlobType.MULTIPART

or

BlobType.BlobDimensionality.MULTIPART

, where in the latter case

pyright

(the static type-checker I'm using in emacs) was complaining, even though it works in both cases. You'll notice that I chose the former case in most search-and-replace, but it might be confusing to use that form in the long run (since it won't be clear which enum is being used as the source for the value). Tracking Issue https://github.com/flyteorg/flyte/issues/ Follow-up issue NA OR https://github.com/flyteorg/flyte/issues/ flyteorg/flytekit WIP: Title contains "wip" GitHub Actions: build (windows-latest, 3.9) GitHub Actions: build (windows-latest, 3.8) GitHub Actions: build (windows-latest, 3.7, -spark2) GitHub Actions: build (windows-latest, 3.7) GitHub Actions: build (ubuntu-latest, 3.10) GitHub Actions: build (ubuntu-latest, 3.9) GitHub Actions: build (ubuntu-latest, 3.8) GitHub Actions: build (ubuntu-latest, 3.7, -spark2) GitHub Actions: build (ubuntu-latest, 3.7) GitHub Actions: build-plugins (3.10, flytekit-vaex) GitHub Actions: build-plugins (3.10, flytekit-sqlalchemy) GitHub Actions: build-plugins (3.10, flytekit-spark) GitHub Actions: build-plugins (3.10, flytekit-snowflake) GitHub Actions: build-plugins (3.10, flytekit-ray) GitHub Actions: build-plugins (3.10, flytekit-polars) GitHub Actions: build-plugins (3.10, flytekit-papermill) GitHub Actions: build-plugins (3.10, flytekit-pandera) GitHub Actions: build-plugins (3.10, flytekit-kf-tensorflow) GitHub Actions: build-plugins (3.10, flytekit-kf-pytorch) GitHub Actions: build-plugins (3.10, flytekit-kf-mpi) GitHub Actions: build-plugins (3.10, flytekit-k8s-pod) GitHub Actions: build-plugins (3.10, flytekit-hive) GitHub Actions: build-plugins (3.10, flytekit-dolt) GitHub Actions: build-plugins (3.10, flytekit-deck-standard) GitHub Actions: build-plugins (3.10, flytekit-dbt) GitHub Actions: build-plugins (3.10, flytekit-data-fsspec) GitHub Actions: build-plugins (3.10, flytekit-bigquery) GitHub Actions: build-plugins (3.10, flytekit-aws-sagemaker) GitHub Actions: build-plugins (3.10, flytekit-aws-batch) ✅ No checks have passed 0/30 successful checks