Channels
datahub-flyte
scipy-2023-workshop
flyte-school
agent-support-memverge
flyte-build
flyte-users-berlin
scipy-2023-sprint
auth
flyte-bazel
large-language-models
contribute
bioinformatics-computational-biology
great-content
in-flyte-conversations
flyte-on-gcp
show-and-tell
shameless-promotion
linkedin-flyte
random
deployment
hacktoberfest-2023
flyte-github
feature-discussions
linen-test
flytelab
flytekit-java
integrations
ray-on-flyte
conference-talks
release
flyte-ui-ux
workflow-building-ui-proj
writing-w-sfloris
jobs
hacktoberfest-2022
torch-elastic
flyte-console
engineeringlabs
helsing-flyte
flyte-documentation
konan-integration
databricks-integration
ray-integration
wg-gpu-types
flytekit
ecosystem-unionml
scipy-2022-sprint
announcements
ask-the-community
flyte-deployment
introductions
events
Powered by
#flytekit
Title
# flytekit
j
jeev
02/15/2022, 6:50 PM
@Yee
@Eduardo Apolinario (eapolinario)
: do y'all think this is still necessary?
https://github.com/flyteorg/flytekit/blob/170f5af72b52997730bd2f8c83596418a632683a/plugins/flytekit-k8s-pod/flytekitplugins/pod/task.py#L122
y
Yee
02/15/2022, 6:54 PM
just ignore pod
and run function right?
i defer to
@Ketan (kumare3)
- I think this is one of those cases where we should ignore correctness and err on the side of user-friendliness
j
jeev
02/15/2022, 6:56 PM
we can leave it up to the users right?
we're looking into overriding this method with the base task method haha
kinda hacky
k
Ketan (kumare3)
02/15/2022, 6:59 PM
I think we should run it
At some point we used to run user code, dont know why the exception got added again
j
jeev
02/15/2022, 7:00 PM
@Greg Gydush
can we open a PR to toss that method in pod tasks?
k
Ketan (kumare3)
02/15/2022, 7:00 PM
👍
j
jeev
02/15/2022, 7:00 PM
or maybe we can add a warning
and run it anyway?
wdyt
@Greg Gydush
k
Ketan (kumare3)
02/15/2022, 7:01 PM
yes i think warning and running it would be great
👍 2
g
Greg Gydush
02/15/2022, 7:38 PM
Added here:
https://github.com/flyteorg/flytekit/pull/852
j
jeev
02/15/2022, 8:05 PM
lgtm! thanks
@Greg Gydush
y
Yee
02/15/2022, 9:49 PM
what version are you guys on?
i’ll cherry pick the pr
j
jeev
02/15/2022, 9:50 PM
we have different teams that are on different versions
but we can consolidate
ok to release to latest version
wdyt
@Greg Gydush
g
Greg Gydush
02/15/2022, 9:50 PM
agreed, cherrypicking to latest would be perfect
y
Yee
02/15/2022, 9:52 PM
https://github.com/flyteorg/flytekit/pull/853
🙏 1
@Eduardo Apolinario (eapolinario)
+1?
👍 1
5 Views
Post