<@UNR3C6Y4T> <@U0265RTUJ5B>: do y'all think this i...
# flytekitf
freezing-boots-56761
02/15/2022, 6:50 PM
@thankful-minister-83577 @high-accountant-32689: do y'all think this is still necessary? https://github.com/flyteorg/flytekit/blob/170f5af72b52997730bd2f8c83596418a632683a/plugins/flytekit-k8s-pod/flytekitplugins/pod/task.py#L122
t
thankful-minister-83577
02/15/2022, 6:54 PM
just ignore pod
thankful-minister-83577
02/15/2022, 6:54 PM
and run function right?
thankful-minister-83577
02/15/2022, 6:55 PM
i defer to @freezing-airport-6809 - I think this is one of those cases where we should ignore correctness and err on the side of user-friendliness
f
freezing-boots-56761
02/15/2022, 6:56 PM
we can leave it up to the users right?
freezing-boots-56761
02/15/2022, 6:57 PM
we're looking into overriding this method with the base task method haha
freezing-boots-56761
02/15/2022, 6:57 PM
kinda hacky
f
freezing-airport-6809
02/15/2022, 6:59 PM
I think we should run it
freezing-airport-6809
02/15/2022, 6:59 PM
At some point we used to run user code, dont know why the exception got added again
f
freezing-boots-56761
02/15/2022, 7:00 PM
@rich-garden-69988
freezing-boots-56761
02/15/2022, 7:00 PM
can we open a PR to toss that method in pod tasks?
f
freezing-airport-6809
02/15/2022, 7:00 PM
👍
f
freezing-boots-56761
02/15/2022, 7:00 PM
or maybe we can add a warning
freezing-boots-56761
02/15/2022, 7:01 PM
and run it anyway?
freezing-boots-56761
02/15/2022, 7:01 PM
wdyt @rich-garden-69988
f
freezing-airport-6809
02/15/2022, 7:01 PM
yes i think warning and running it would be great
👍 2
r
rich-garden-69988
02/15/2022, 7:38 PMAdded here: https://github.com/flyteorg/flytekit/pull/852
f
freezing-boots-56761
02/15/2022, 8:05 PM
lgtm! thanks @rich-garden-69988
t
thankful-minister-83577
02/15/2022, 9:49 PM
what version are you guys on?
thankful-minister-83577
02/15/2022, 9:49 PM
i’ll cherry pick the pr
f
freezing-boots-56761
02/15/2022, 9:50 PM
we have different teams that are on different versions
freezing-boots-56761
02/15/2022, 9:50 PM
but we can consolidate
freezing-boots-56761
02/15/2022, 9:50 PM
ok to release to latest version
freezing-boots-56761
02/15/2022, 9:50 PM
wdyt @rich-garden-69988
r
rich-garden-69988
02/15/2022, 9:50 PMagreed, cherrypicking to latest would be perfect
t
thankful-minister-83577
02/15/2022, 9:52 PM
thankful-minister-83577
02/15/2022, 9:53 PM
@high-accountant-32689 +1?
👍 1
169 Views