Channels
announcements
ask-the-community
auth
conference-talks
contribute
databricks-integration
datahub-flyte
deployment
ecosystem-unionml
engineeringlabs
events
feature-discussions
flyte-bazel
flyte-build
flyte-console
flyte-deployment
flyte-documentation
flyte-github
flyte-on-gcp
flyte-ui-ux
flytekit
flytekit-java
flytelab
great-content
hacktoberfest-2022
helsing-flyte
in-flyte-conversations
integrations
introductions
jobs
konan-integration
linkedin-flyte
random
ray-integration
ray-on-flyte
release
scipy-2022-sprint
show-and-tell
sig-large-models
torch-elastic
workflow-building-ui-proj
writing-w-sfloris
Title
j
jeev
02/15/2022, 6:50 PM@Yee @Eduardo Apolinario (eapolinario): do y'all think this is still necessary? https://github.com/flyteorg/flytekit/blob/170f5af72b52997730bd2f8c83596418a632683a/plugins/flytekit-k8s-pod/flytekitplugins/pod/task.py#L122
y
Yee
02/15/2022, 6:54 PMjust ignore pod
and run function right?
i defer to @Ketan (kumare3) - I think this is one of those cases where we should ignore correctness and err on the side of user-friendliness
j
jeev
02/15/2022, 6:56 PMwe can leave it up to the users right?
we're looking into overriding this method with the base task method haha
kinda hacky
k
Ketan (kumare3)
02/15/2022, 6:59 PMI think we should run it
At some point we used to run user code, dont know why the exception got added again
j
jeev
02/15/2022, 7:00 PM@Greg Gydush
can we open a PR to toss that method in pod tasks?
k
Ketan (kumare3)
02/15/2022, 7:00 PM👍
j
jeev
02/15/2022, 7:00 PMor maybe we can add a warning
and run it anyway?
wdyt @Greg Gydush
k
Ketan (kumare3)
02/15/2022, 7:01 PMyes i think warning and running it would be great
👍 2
g
Greg Gydush
02/15/2022, 7:38 PMAdded here: https://github.com/flyteorg/flytekit/pull/852
j
jeev
02/15/2022, 8:05 PMlgtm! thanks @Greg Gydush
y
Yee
02/15/2022, 9:49 PMwhat version are you guys on?
i’ll cherry pick the pr
j
jeev
02/15/2022, 9:50 PMwe have different teams that are on different versions
but we can consolidate
ok to release to latest version
wdyt @Greg Gydush
g
Greg Gydush
02/15/2022, 9:50 PMagreed, cherrypicking to latest would be perfect
y
Yee
02/15/2022, 9:52 PM@Eduardo Apolinario (eapolinario) +1?
👍 1