https://flyte.org logo
Join Slack
Powered by
hey <@U0265RTUJ5B> <@UNR3C6Y4T> <@U03LYJNCFB5> I n...
# flytekit
b
hey @high-accountant-32689 @thankful-minister-83577 @happy-river-91250 I noticed that all our OSS conda-forge versions are out of date: • https://anaconda.org/conda-forge/flytekit • https://anaconda.org/conda-forge/unionml • https://anaconda.org/conda-forge/flyteidl We should discuss how we want to manage this… I believe all we need is someone from the internal team to have access to the corresponding feedstocks so we can merge the auto-PRs that are made when we update these packages on pypi.
h
good catch. So we should add the 3 of us as maintainers to each of the 3 feedstock repos (https://github.com/conda-forge/flytekit-feedstock, etc), right? Is there any way we can automate these feedstock PRs once we have a release of any of the libraries? I don't have experience with maintaining conda packages.
b
yep! @happy-river-91250 do you own those feedstack repos?
f
Cc @agreeable-kitchen-44189
h
Hi @broad-monitor-993 Yes. I am a/one-of-the maintainer(s) of these repositories. Please feel free to send a PR to the feedstocks and I will take a look. This will be a good opportunity for us to do some knowledge transfer as well. We will need more people from the community to maintain all the feedstocks on conda-forge (including the plug-ins). cc: @high-accountant-32689 @freezing-airport-6809
b
@happy-river-91250 @high-accountant-32689 can we re-consider how we’re maintaining 
flytekitplugins-*
in conda forge? I’m not so confident that our current approach is maintainable… basically any time we release a new version of flytekit and flytekitplugins we’ll have to manually approve all 
x
plugins in 
x
different repos… I forget the tradeoff of having one recipe file for all the plugins, but that would be a lot easier to manage, e.g. in pandera it’s a single recipe: https://github.com/conda-forge/pandera-feedstock/blob/main/recipe/meta.yaml
I’m also seeing inconsistent behavior on conda-forge… there are a bunch on unmerged auto-PRs in flytekit feedstock but some of the most recent releases (e.g. 1.2.7) aren’t on there
a
@broad-monitor-993 Has there been any progress on this? If not, do you mind if I start updating 
flyteidl
?
b
hi @agreeable-kitchen-44189 not yet, still need to fix CI issues here https://github.com/conda-forge/flytekit-feedstock/pull/25
not, do you mind if I start updating 
flyteidl
?
please do! you’re talking about https://github.com/conda-forge/flyteidl-feedstock right?
a
Exactly! Would you prefer if I do all old versions as well or do you think latest is good enough?
b
I think the latest is good enough!
a
Nice thanks! Let’s see how long that takes, PR is here
💯 1
b
@happy-river-91250 would you mind taking a look at this PR ^^ ?
@high-accountant-32689 @thankful-minister-83577 there’s a flytekit conda-forge CI error for the latest release: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=640819&amp;vi[…]9ba3-09c10d0bea97&amp;t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d&amp;l=324
Copy code
AttributeError: module 'numpy' has no attribute 'bool'. Did you mean: 'bool_'?
@high-accountant-32689 @thankful-minister-83577 we need to pin numpy in conda recipe. As the recipe is currently set up, we need to pin it to a version that works across all supported python versions… if we want to do python version-specific versions we’ll need to update the receipe (@happy-river-91250 may be able to advice on the best way to do that) To expedite this though, I’d recommend pinning to 
numpy < 1.22.0
so that it works for python 3.7
h
We pinned numpy's version in https://github.com/flyteorg/flytekit/pull/1376. I'll invest time today to bring the flytekit conda recipe to match what's in flytekit master.
155 Views
Open in Slack
PreviousNext
Powered by