https://flyte.org logo
Title
n

Niels Bantilan

12/16/2022, 3:09 PM
hey @Eduardo Apolinario (eapolinario) @Yee @Sugato Ray I noticed that all our OSS conda-forge versions are out of date: • https://anaconda.org/conda-forge/flytekithttps://anaconda.org/conda-forge/unionmlhttps://anaconda.org/conda-forge/flyteidl We should discuss how we want to manage this… I believe all we need is someone from the internal team to have access to the corresponding feedstocks so we can merge the auto-PRs that are made when we update these packages on pypi.
e

Eduardo Apolinario (eapolinario)

12/16/2022, 7:30 PM
good catch. So we should add the 3 of us as maintainers to each of the 3 feedstock repos (https://github.com/conda-forge/flytekit-feedstock, etc), right? Is there any way we can automate these feedstock PRs once we have a release of any of the libraries? I don't have experience with maintaining conda packages.
n

Niels Bantilan

12/16/2022, 7:37 PM
yep! @Sugato Ray do you own those feedstack repos?
k

Ketan (kumare3)

12/19/2022, 3:49 PM
Cc @Bernhard Stadlbauer
s

Sugato Ray

12/19/2022, 3:57 PM
Hi @Niels Bantilan Yes. I am a/one-of-the maintainer(s) of these repositories. Please feel free to send a PR to the feedstocks and I will take a look. This will be a good opportunity for us to do some knowledge transfer as well. We will need more people from the community to maintain all the feedstocks on conda-forge (including the plug-ins). cc: @Eduardo Apolinario (eapolinario) @Ketan (kumare3)
n

Niels Bantilan

12/21/2022, 3:40 PM
@Sugato Ray @Eduardo Apolinario (eapolinario) can we re-consider how we’re maintaining
flytekitplugins-*
in conda forge? I’m not so confident that our current approach is maintainable… basically any time we release a new version of flytekit and flytekitplugins we’ll have to manually approve all
x
plugins in
x
different repos… I forget the tradeoff of having one recipe file for all the plugins, but that would be a lot easier to manage, e.g. in pandera it’s a single recipe: https://github.com/conda-forge/pandera-feedstock/blob/main/recipe/meta.yaml
I’m also seeing inconsistent behavior on conda-forge… there are a bunch on unmerged auto-PRs in flytekit feedstock but some of the most recent releases (e.g. 1.2.7) aren’t on there
b

Bernhard Stadlbauer

01/13/2023, 2:08 PM
@Niels Bantilan Has there been any progress on this? If not, do you mind if I start updating
flyteidl
?
n

Niels Bantilan

01/13/2023, 2:11 PM
hi @Bernhard Stadlbauer not yet, still need to fix CI issues here https://github.com/conda-forge/flytekit-feedstock/pull/25
not, do you mind if I start updating
flyteidl
?
please do! you’re talking about https://github.com/conda-forge/flyteidl-feedstock right?
b

Bernhard Stadlbauer

01/13/2023, 2:14 PM
Exactly! Would you prefer if I do all old versions as well or do you think latest is good enough?
n

Niels Bantilan

01/13/2023, 2:15 PM
I think the latest is good enough!
b

Bernhard Stadlbauer

01/13/2023, 2:18 PM
Nice thanks! Let’s see how long that takes, PR is here
n

Niels Bantilan

01/13/2023, 2:50 PM
@Sugato Ray would you mind taking a look at this PR ^^ ?
e

Eduardo Apolinario (eapolinario)

01/13/2023, 4:45 PM
We pinned numpy's version in https://github.com/flyteorg/flytekit/pull/1376. I'll invest time today to bring the flytekit conda recipe to match what's in flytekit master.