https://flyte.org logo
s

Sugato Ray

06/28/2022, 1:19 AM
In my experience, people often have some questions about conda-forge packaging. I have tried to put together some FAQ's in the discussions under UnionML repository. I hope this helps in future. • https://github.com/unionai-oss/unionml/discussions/137
excellent 1
💯 2
k

Ketan (kumare3)

06/28/2022, 2:39 AM
@Sugato Ray did you add flytekit to conda too?
s

Sugato Ray

06/28/2022, 3:13 AM
@Ketan (kumare3) I updated
flytekit
and
flyteidl
from their older versions to the latest ones on conda-forge. Was necessary for adding
unionml
. So, currently I am the maintainer of all three packages on conda-forge.
k

Ketan (kumare3)

06/28/2022, 3:15 AM
Ohh but we do not have an auto publish for flytekit and flyteidl
Can you please do that as well - highly appreciated 👏
s

Sugato Ray

06/28/2022, 3:16 AM
conda-forge does not allow auto publish
k

Ketan (kumare3)

06/28/2022, 3:16 AM
Ohh really
So Everyone manually publishes?
s

Sugato Ray

06/28/2022, 3:20 AM
In short: if no new dependency was added to the code base, then right after a PyPI release, there is a conda-forge bot that will create an update package. But if dependencies change, or the indirect dependencies change, then you might need manual intervension -- like it was necessary this time. Ideally, the maintainer will upgrade the package. But PRs are welcome. Once a PyPI release happens, please raise an issue at the feedstock or send a PR.
❤️ 1
k

Ketan (kumare3)

06/28/2022, 3:27 AM
Cc @Yee the e should this to readme
Cc @Samhita Alla
n

Niels Bantilan

06/28/2022, 2:58 PM
we should also create a
flytekitplugins
conda package where we maintain all the first-party plugins. We can create a recipe that publishes all plugins in one. See the
pandera
recipe as an example: https://github.com/pandera-dev/pandera-feedstock/blob/master/recipe/meta.yaml
y

Yee

06/28/2022, 3:07 PM
i think that makes sense if that’s alright with you @Sugato Ray
n

Niels Bantilan

06/28/2022, 3:08 PM
created this issue: https://github.com/flyteorg/flyte/issues/2636 @Sugato Ray let me know if you’d by down to make a contribution on this front!
y

Yee

06/28/2022, 3:08 PM
also, we’re going to be cutting the next flytekit release later this week or early next, mind walking through any steps there are to do sugato? and then maybe I can document them?
k

Ketan (kumare3)

06/28/2022, 3:21 PM
@Niels Bantilan that would be great to become co maintainers
s

Sugato Ray

06/28/2022, 5:08 PM
About becoming co-maintainers: I will be glad to add some people. But let's only add people as co-maintainers, once they have updated a recipe and better yet once they have created a new conda-forge recipe. So, let's take steps toward sending PRs first to the feedstocks. Let's first get you more comfortable with fixing all build errors, and if necessary, creating newer recipes. But, I appreciate this discussion of having more co-maintainers. 👏 cc: @Niels Bantilan @Ketan (kumare3) @Yee
@Yee The flytekit update on pypi has some bugs. This breaks the conda-forge builds. I have opened a PR on GitHub. Once these are fixed, the conda-forge package can update to the latest version. https://github.com/flyteorg/flytekit/pull/1088
y

Yee

07/05/2022, 4:10 PM
thanks.
yeah also we cut 1.1
will merge this and make a 1.1 i think, off the release branch
s

Sugato Ray

07/06/2022, 6:20 PM
@Yee Please let me know if any other changes are necessary in the PR.
y

Yee

07/07/2022, 4:14 PM
hey sorry i forgot to respond
can you take a look at the test failure kevin mentioned?
it’s not a unit test unf.
but in using it it doesn’t seem to render anymore
s

Sugato Ray

07/09/2022, 1:55 AM
Thank you. I will look into it.
16 Views