Hi tyring out `flytekit extras` types but it doesn t seem to

Question

Hi tyring out `flytekit extras` types but it doesn t seem to exist in `flytekit` v1 2 3 do I need to install a separate module for this

Kevin Su · Answer

What kind of type you want to use in extras

seunggs · Answer

`flytekit extras pytorch PyTorchCheckpoint`

Kevin Su · Answer

it still exists in the extras <https github com flyteorg flytekit blob dd3fcaea3604f606c98b05ce05e3a8fc7d520906 flytekit extras pytorch checkpoint py L25>

Niels Bantilan · Answer

do you have `torch` installed The `flytekit extras pytorch` module transformers are only registered if the `torch` package is installed <https github com flyteorg flytekit blob dd3fcaea3604f606c98b05ce05e3a8fc7d520906 flytekit extras pytorch init py L25 L31>

seunggs · Answer

Yes I do have torch installed and imported

seunggs · Answer

Still getting this error ```AttributeError module flytekit extras has no attribute pytorch ```

Samhita Alla · Answer

```from flytekit extras pytorch import PyTorchCheckpoint``` This import should work What s your flytekit version

seunggs · Answer

`1 2 3`

Samhita Alla · Answer

I have the same version and it works for me

Samhita Alla · Answer

Can you re install flytekit and verify

seunggs · Answer

I can t try it now but I will in the next couple of days and report back

seunggs · Answer

Thanks for looking into it

Samhita Alla · Answer

Sure no problem

seunggs · Answer

< Samhita Alla> this is just out of curiosity since I m still trying to get my head around Python but looking at the docs ```flytekit types file PythonPickledFile = lt class flytekit types file file FlyteFile class getitem lt locals gt SpecificFormatClass gt ```

seunggs · Answer

So shouldn t specifying `flytekit types file PythonPickledFile` as the return type hint be the same as `flytekit types file file FlyteFile class getitem lt locals gt SpecificFormatClass`

seunggs · Answer

But the latter errors out during `pylint` and also in the editor with parsing error

seunggs · Answer

Couldn t find a lot of info on ` class getitem lt locals gt SpecificFormatClass` would you mind giving me a bit of context as to what this is

seunggs · Answer

I tried creating a function with return type hint of `flytekit types file PythonPickledFile` and then running `typing get type hints` returns `flytekit types file file FlyteFile class getitem lt locals gt SpecificFormatClass`

Samhita Alla · Answer

Here s the relevant code to understand that <https github com flyteorg flytekit blob f2dd4aa146fa2886b469c31a6eda0c392567fb56 flytekit types file file py L151> So `PythonPickledFile` can be thought of as `FlyteFile Annotated str pickle ` and hence you get that type ` class getitem ` is to capture the item in ` ` in FlyteFile `PythonPickledFile` shouldn t be used externally it s automatically used by Flytekit when the type isn t recognizable So you needn t worry about it

seunggs · Answer

What is ` lt locals gt ` here

seunggs · Answer

Is that a valid python syntax

Eduardo Apolinario (eapolinario) · Answer

< seunggs> this is just to indicate that we re returning an object of a class defined inside ` class getitem `

Eduardo Apolinario (eapolinario) · Answer

can you share the code you re seeing this How are you running it

seunggs · Answer

Yeah so I m just trying to understand this better I m running ```def test fn gt flytekit types file FlyteFile csv pass```

seunggs · Answer

```typing get type hints test fn ```

seunggs · Answer

The result is

seunggs · Answer

``` return lt class flytekit types file file FlyteFile class getitem lt locals gt SpecificFormatClass gt ```

seunggs · Answer

And regardless of what string value I put into the FlyteFile type I get the same return type hint

seunggs · Answer

Wondering why that is

Samhita Alla · Answer

If you put `FlyteFile` as the return type then you wouldn t be getting that

seunggs · Answer

Right `FlyteFile` works fine `FlyteFile csv ` does not

Samhita Alla · Answer

No it does work fine It s that it calls that inner class and returns that as a type Are you facing any issue with that

seunggs · Answer

Oh yeah I didn t mean it doesn t work it s just strange what `typing get type hint` returns on a function that uses `FlyteFile csv `

seunggs · Answer

Maybe `typing get type hint` doesn t know how to deal with ` class getitem `

Samhita Alla · Answer

I don t think so ` SpecificFormatClass` subclasses `FlyteFile` so it s returning the right type

seunggs · Answer

OK I guess I m not understanding this correctly so `FlyteFile csv ` and `FlyteFile png ` are the same type but with different metadata using `typing extensions Annotated` So there s no way to differentiate between the two if I were to use `typing get type hint` to get types For example if I were to run `typing get type hint` for `FlyteFile csv ` and `FlyteFile png ` both would return the same ` SpecificFormatClass` any way to find out which is which

Eduardo Apolinario (eapolinario) · Answer

< seunggs> under the covers i e when we convert the types to the Flyte type system `FlyteFile csv ` does not match `FlyteFile png ` similarly `FlyteFile Annotated str FileExt abc ` is not going to match `FlyteFile Annotated str FileExt def ` If I understand your concern correctly you want better typehints in that case I agree flytekit could use some work to provide better type hints to static type checkers like mypy or pyright Can you open a github issue to track this The support for types is way more mature now than when `FlyteFile` was initially written so possibly we ll be able to improve the ux there

seunggs · Answer

Oh I see got it Will open an issue in github

seunggs · Answer

Thanks

Eduardo Apolinario (eapolinario) · Answer

thank you