https://flyte.org logo
s

Sören Brunk

05/03/2022, 9:08 AM
I just tried upgrading to
flyteadmin:1.0.1
for the stow fix https://github.com/flyteorg/flyteadmin/pull/416 but now flyteconsole fails with a 500. "Request failed with status code 500 header key "userinfo" contains value with non-printable ASCII characters"
k

katrina

05/03/2022, 4:25 PM
cc @Prafulla Mahindrakar
p

Prafulla Mahindrakar

05/04/2022, 5:19 AM
I have GCP deployment where i didn’t see this issue. May be its affecting only auth enabled admins. Let me try to enable auth on my setup and check too
👍 1
Hi @Sören Brunk which screen do you encounter this issue . I tried to enable OpenId connect using google auth and i am able to load console
s

Sören Brunk

05/04/2022, 7:18 AM
@Prafulla Mahindrakar as soon as I load console when logged in. Does
userinfo
contain the full name perhaps coming from auth? Then it could be triggered because of the non-ascii ö in my name.
p

Prafulla Mahindrakar

05/04/2022, 7:20 AM
User info would be shared by openid connect provider . I was able to login using my name but yeah could be due to non ascii char in yours
Ok the api on api/v1/projects is it also the same issue ?
s

Sören Brunk

05/04/2022, 7:21 AM
yes
p

Prafulla Mahindrakar

05/04/2022, 7:21 AM
Ok . Let me check more
s

Sören Brunk

05/04/2022, 7:25 AM
Yeah I think that's the issue indeed. I changed my name in Google Accounts removing the umlaut to test and now it works.
p

Prafulla Mahindrakar

05/04/2022, 7:29 AM
Awesome .
Did it work with umlaut in previous admin versions.
s

Sören Brunk

05/04/2022, 7:33 AM
yes it's working with 1.0.0
p

Prafulla Mahindrakar

05/04/2022, 7:38 AM
Ok its due to update to GRPC which now doesn’t allow non-ascii chars in headers . Heres the issue https://github.com/grpc/grpc-go/issues/468 Which got fixed in this PR https://github.com/grpc/grpc-go/pull/4886 With the latest flyteadmin its pulling in the fix for this aswell and hence you are encountering this issue only with the latest admin version
Probably google should be changing its api not to send this info in header?
s

Sören Brunk

05/04/2022, 7:56 AM
Do you know where this is actually put into the header?
This irrespective of the provider so seems with latest GRPC library update non-ascii chars in metadata wont work.
And we use this in the IdentityContext . I will open up an issue for this but you should be unbocked by changing of the name .
👍 1
cc : @Haytham Abuelfutuh
s

Sören Brunk

05/04/2022, 9:23 AM
Thanks @Prafulla Mahindrakar!
6 Views