It seems that after <this change> our flyte servic...
# announcements
b
It seems that after this change our flyte services have excessive logging related to gorm, logging queries and formatting is ignored etc. more in the ๐Ÿงต
These are some of the logs
Copy code
{"data":{"exec_id":"asv3vube3bfeszn65jv6","src":"execution_manager.go:499"},"message":"getting the workflow execution config from request spec","severity":"INFO","timestamp":"2022-05-02T11:59:08Z"}
{"data":{"exec_id":"asv3vube3bfeszn65jv6","src":"execution_manager.go:792"},"message":"Setting security context from auth Role","severity":"WARNING","timestamp":"2022-05-02T11:59:08Z"}

2022/05/02 11:56:15 /go/src/github.com/flyteorg/flyteadmin/pkg/repositories/gormimpl/execution_repo.go:44
[18.514ms] [rows:1] SELECT * FROM "executions" WHERE "executions"."execution_project" = 'some-3rd-project' AND "executions"."execution_domain" = 'production' AND "executions"."execution_name" = 'enh4ai5ojr5hdvgijjur' LIMIT 1

2022/05/02 11:56:15 /go/src/github.com/flyteorg/flyteadmin/pkg/repositories/gormimpl/execution_repo.go:103
[17.658ms] [rows:0] SELECT * FROM "executions" WHERE executions.execution_project = 'some-project-other' AND executions.execution_domain = 'development' AND executions.phase in ('RUNNING') AND executions.started_at >= '2022-04-08T11:56:15' AND executions.started_at <= '2022-05-02T11:46:15' AND executions.state = 'EXECUTION_ACTIVE' LIMIT 100

2022/05/02 11:56:15 /go/src/github.com/flyteorg/flyteadmin/pkg/repositories/gormimpl/execution_repo.go:103
[34.685ms] [rows:0] SELECT * FROM "executions" WHERE executions.execution_project = 'some-project' AND executions.execution_domain = 'production' AND executions.phase in ('RUNNING') AND executions.started_at >= '2022-04-08T11:56:15' AND executions.started_at <= '2022-05-02T11:46:15' AND executions.state = 'EXECUTION_ACTIVE' LIMIT 100
our config looks like:
Copy code
flyteadmin_config.yaml: |
    logger:
      show-source: true
      level: 4 
      formatter:
        type: gcp
did we miss something?
k
hey Babis, can you downgrade the log level from info?
b
Sure we could do that, but I am not sure if we lose any important logs right now. Does it makes more sense to log the queries on debug instead?
Also the formatting type was not honored
k
what do you mean by formatting type?
also sure! excellent suggestion, gorm's log levels don't quite correspond to the flyte config ones so getting the translation right is ambiguous ๐Ÿ˜…
b
By formatting I mean that they are not json formatted like the first 2 logs I shared
k
oh I see, this is just the raw output from the gorm logger without any formatting from the flytestdlib logger
๐Ÿ‘ 1
b
thanks a lot I approved the PR ๐Ÿ‘
k
thanks @Babis Kiosidis we'll be releasing a patch Flyte release today with the admin & datacatalog deps updated to the latest stdlib, will keep you posted
โค๏ธ 1
v1.0.1 is out!
b
๐Ÿ™
109 Views