https://flyte.org logo
#flytekit
Title
# flytekit
j

jeev

05/18/2022, 9:26 PM
do we already have a workaround or fix for this? https://github.com/flyteorg/flyte/issues/2508
k

Ketan (kumare3)

05/18/2022, 9:37 PM
cc @jeev can you push a PR?
j

jeev

05/18/2022, 10:08 PM
@Ketan (kumare3): curious if the change make sense, or should this be handled on flyteadmin's side.
we are slightly behind on our versions, so it may already have been fixed
@Vrinda Vasavada: would be useful to list our versions in the issue as well
👍 1
y

Yee

05/18/2022, 10:41 PM
i think this makes sense… thank you for finding it. mind putting in the PR?
v

Vrinda Vasavada

05/18/2022, 10:50 PM
yeah I can put the PR out! we're on flytekit
0.30.3
and flyteidl
0.22.3
(will add these to the issue too)
k

Ketan (kumare3)

05/18/2022, 10:51 PM
hmm we are on 1.0.2 now
v

Vrinda Vasavada

05/19/2022, 12:01 AM
yeahhh we need to upgrade all of our projects but are a bit behind! I'll put out the PR and will link the other possible location for this fix on the flyteadmin side
j

jeev

05/19/2022, 7:19 PM
yea we’re working on the upgrade across the org.
would be good to confirm if this is still an issue in 1.0.2. maybe we can try to repro against the latest flyte @Vrinda Vasavada ?
v

Vrinda Vasavada

05/19/2022, 8:38 PM
yeah agreed! i'll try upgrading our sandbox and see if I can reproduce this
okay, still the same issue with
flytekit==1.0.2
and
flyteidl==1.0.1
@Eduardo Apolinario (eapolinario) thanks for approving and merging it in! would it be possible to release a patched version of
0.26.1
with this fix in the meantime while we work on upgrading to
1.0.2
?
e

Eduardo Apolinario (eapolinario)

05/24/2022, 1:12 AM
@Vrinda Vasavada, I just released 0.26.2. Can you give it a try and let us know if it solved the issue for you?
v

Vrinda Vasavada

05/24/2022, 4:31 PM
thanks a bunch! will try it out!
that fixed it, thank you @Eduardo Apolinario (eapolinario)!
e

Eduardo Apolinario (eapolinario)

05/24/2022, 8:55 PM
Amazing. Thank you for the fix, @Vrinda Vasavada!
❤️ 1
26 Views