https://flyte.org logo
Join Slack
Powered by
Hey :wave: I have opened two PRs extending the AW...
# contribute
a
Hey 👋 I have opened two PRs extending the AWS SageMaker plugin, and would appreciate a review on it. Today the plugin only covers inference endpoints. These add the rest of the SageMaker job surface: • #3456: managed job connectors: 
training
, 
processing
, 
batch transform
, 
hyperparameter tuning
, and 
Inference Recommender
. You supply the boto3 config and the connector handles submission, polling, and cancellation. github.com/flyteorg/flytekit/pull/3456 • #3459: Pythonic mode for training and processing, so you can write a plain 
@task
and have it run inside the SageMaker container instead of authoring a config blob. Modelled on the EMR Serverless plugin's dual-mode approach. Stacked on #3456, currently draft. github.com/flyteorg/flytekit/pull/3459 Both are covered by unit tests and have been exercised against real SageMaker jobs. Rationale and design notes are in the PR descriptions. Happy to split, rework, or rebase these however suits the maintainers.
FYI: @freezing-airport-6809 since you initially created the SageMaker connector, above PR extending it and add all the new funcioanlity SageMaker supports so using Flyte we can Run Training and Batch on SageMaker.
g
@adventurous-ability-21671 thanks, I’ll take a look today
a
Thanks @glamorous-carpet-83516 🙌
g
@adventurous-ability-21671 btw, do you get a chance to try flyte v2 https://www.union.ai/blog-post/flyte-2-is-generally-available-the-durable-open-source-ai-runtime
a
Yes, I shared this with the team yesterday and this is in active discussion, will soon start exploring this.
Hey @glamorous-carpet-83516 following up on it, whenever you get chance can you look into the PR, please? we have tested it internally working perfectly fine. It will be good if it can come from upstream so we don't need to maintain our own local fork.
g
sorry, looking now, got distracted by other things last week.
👍 1
@adventurous-ability-21671 I +1 github.com/flyteorg/flytekit/pull/3456, could you rebase the other two PRs
a
Thanks Kevin! Rebased #3459 onto master clean, no conflicts. its only red check is 
flytekit-greatexpectations
, which fails on an external 404 unrelated to these changes. github.com/flyteorg/flytekit/pull/3459
g
merged, thanks. would you mind adding the v2 sagemaker connector once you migrate to v2 flyte?
a
Thanks and yes, I will do that for both the plugins EMR Serverless as well as SageMaker. Could you also release the connector later version? so I can upgrade our internal deployment just make sure everything is working fine from upstream as well. Once its done my next immediate target is to get Flyte 2 as separate fleet up and running.
🦜 1
🙏 1
g
a
Will get that rolled, thanks again 🙌🏻
Hey @glamorous-carpet-83516 just an update, we upgraded our internal deployment with latest connector version everything seems to be working fine no bug no issues. Will reach out when I am ready with v2 connector.
g
Awesome, good to see everything is working
2 Views
Open in Slack
PreviousNext
Powered by