<#7409 feat(connector): handle TaskExecution_RETRY...
# flyte-github
a
#7409 feat(connector): handle TaskExecution_RETRYABLE_FAILED phase Pull request opened by pingsutw Tracking issue Why are the changes needed? The webapi connector plugin currently only handles
TaskExecution_FAILED
and
TaskExecution_ABORTED
as failure phases. The
TaskExecution_RETRYABLE_FAILED
phase (value
8
in
flyteidl2/core/execution.proto
) is silently ignored, falling through to the default branch which returns an "unknown execution phase" system error. As a result, a connector that legitimately reports a retryable failure surfaces as a system error to propeller and the task's retry policy is never honored. What changes were proposed in this pull request? In `flyteplugins/go/tasks/plugins/webapi/connector/plugin.go`: 1.
ResourceWrapper.IsTerminal()
now treats
TaskExecution_RETRYABLE_FAILED
as terminal alongside `SUCCEEDED`/`FAILED`/`ABORTED`, so the framework skips an extra
Get
round-trip to the connector once it has returned this phase. 2. The phase switch in
Status
maps
TaskExecution_RETRYABLE_FAILED
to
core.PhaseInfoRetryableFailure(...)
, so propeller retries per the task's retry policy instead of marking the node as permanently failed. How was this patch tested? Built locally with
go build ./flyteplugins/go/tasks/plugins/webapi/connector/...
. No existing tests covered the previous default-branch behavior; happy to add a unit test for both
IsTerminal()
and the phase mapping if reviewers prefer. Labels • added Setup process N/A Screenshots N/A Check all the applicable boxes • I updated the documentation accordingly. • All new and existing tests passed. • All commits are signed-off. Related PRs Stack Docs link flyteorg/flyte