<#7342 change settings label type from list to map...
# flyte-github
a
#7342 change settings label type from list to map to align with k8s Pull request opened by afbrock Tracking issue Why are the changes needed? Kubernetes labels are in key value pairs, and our task proto has them as key value pairs, so to make settings integrate with that seamlessly (and to allow overrides to seamlessly update specific label values) we need the settings type to also be a map. What changes were proposed in this pull request? this just changes the settings label type. (and re-generate all generated files) How was this patch tested? in conjunction with cloud PR, in unit test and devbox. After this is merged and before the cloud change is merged, i will run it in staging. Labels Please add one or more of the following labels to categorize your PR: • added: For new features. • changed: For changes in existing functionality. • deprecated: For soon-to-be-removed features. • removed: For features being removed. • fixed: For any bug fixed. • security: In case of vulnerabilities This is important to improve the readability of release notes. Setup process Screenshots Check all the applicable boxes • I updated the documentation accordingly. • All new and existing tests passed. • All commits are signed-off. Related PRs Stack If you do use
git town
to manage PR Stacks, the stack relevant to this PR will show below. Otherwise, you can ignore this section. Docs link flyteorg/flyte