<#7337 fix(dataproxy): GetActionData returns empty...
# flyte-github
a
#7337 fix(dataproxy): GetActionData returns empty inputs for sub-actions Pull request opened by pingsutw Tracking issue n/a Why are the changes needed?
GetActionData
works for root actions but returns empty inputs for sub-actions. Verified against a live cluster: • Root action stored
RunInfo.InputsUri = s3://flyte-data/uploads/.../offloaded-inputs/<hash>
(prefix only). • Sub-action stored
RunInfo.InputsUri = s3://flyte-data/.../<sub>/inputs.pb
(full path).
dataproxy.GetActionData
unconditionally appended
inputs.pb
to the stored URI: baseRef := storage.DataReference(urisResp.Msg.GetInputsUri()) inputRef, _ := s.dataStore.ConstructReference(groupCtx, baseRef, "inputs.pb") For root that resolved to the real file; for sub-actions it produced
.../inputs.pb/inputs.pb
and 404'd silently. What changes were proposed in this pull request? Normalize on storing the full file path in
RunInfo.InputsUri
and let the dataproxy read it verbatim: • `runs/service/run_service.go`:
persistRunModel
now stores
inputPrefix + "/inputs.pb"
, matching what sub-actions already store via
recordSingleAction
. • `dataproxy/service/dataproxy_service.go`: drop the
ConstructReference(..., "inputs.pb")
and read
InputsUri
directly. How was this patch tested? • Updated unit tests in
dataproxy/service/dataproxy_service_test.go
and
runs/service/run_service_test.go
to reflect the new contract. •
go test ./dataproxy/service/... ./runs/service/...
passes. • Verified the bug end-to-end against a local cluster (DB + RustFS) before the fix. Labels fixed Check all the applicable boxes • I updated the documentation accordingly. (n/a) • All new and existing tests passed. • All commits are signed-off. flyteorg/flyte