<#7334 fix(devbox-bundled): remove leftover istio ...
# flyte-github
a
#7334 fix(devbox-bundled): remove leftover istio refs from knative manifests Pull request opened by pingsutw Why are the changes needed? When starting the bundled devbox, k3s logs:
Copy code
Failed to process config: failed to process /var/lib/rancher/k3s/server/manifests/flyte.yaml:
failed to create istio-system/knative-local-gateway /v1, Kind=Service for kube-system/flyte:
namespaces "istio-system" not found
The bundled Knative install shipped with upstream net-istio defaults — a
Service knative-local-gateway
in the
istio-system
namespace, two istio
Gateway
custom resources, and a
config-istio
ConfigMap pointing the local gateway at istio. Devbox uses kourier as its ingress and never creates the
istio-system
namespace (and istio CRDs aren't installed either), so: • The
Service
apply failed every startup (the visible log error). • The two
networking.istio.io/v1beta1 Gateway
CRs silently failed to apply (CRD missing). • Knative routing still worked because kourier handles ingress, but the noisy errors confused users. What changes were proposed in this pull request? In
kustomize/{complete,dev}/kustomization.yaml
, add patches that: 1. Repoint `config-istio`'s
local-gateway.knative-serving.knative-local-gateway
from
knative-local-gateway.istio-system.svc.cluster.local
→
kourier-internal.kourier-system.svc.cluster.local
. 2. Delete the
Service knative-local-gateway
in
istio-system
. 3. Delete the
Gateway knative-local-gateway
in
knative-serving
(istio CRD). 4. Delete the
Gateway knative-ingress-gateway
in
knative-serving
(istio CRD). Regenerate
manifests/complete.yaml
and
manifests/dev.yaml
so the rendered output matches. How was this patch tested? Built and started the devbox image locally; the
namespaces "istio-system" not found
error no longer appears in the k3s startup log, and Knative cluster-local routing through kourier still works. Labels fixed Check all the applicable boxes • I updated the documentation accordingly. • All new and existing tests passed. • All commits are signed-off. flyteorg/flyte