<#7284 Delegate RunService.GetActionData to DataPr...
# flyte-github
a
#7284 Delegate RunService.GetActionData to DataProxyService Pull request opened by BarryWu0812 Delegate RunService.GetActionData to DataProxyService to remove duplicate implementation Closes #7253 Why are the changes needed? Today both services: • Hold a
storage.DataStore
and implement parallel reads of
inputs.pb
/ outputs via
errgroup
. • Resolve storage URIs from the action record (DataProxy goes through RunService.GetActionDataURIs; RunService reads them directly from the DB). • Must stay in lock-step whenever we evolve the storage layout, artifact types, or error semantics (not found, partial results, trace vs task actions, etc.). This is duplicate surface area with no good reason now that DataProxy owns data access. It also makes the storage-layout contract implicit in two places. What changes were proposed in this pull request? Refactor
RunService.GetActionData
into a thin shim that forwards to `DataProxyServiceClient.GetActionData`: • Inject a
dataproxyconnect.DataProxyServiceClient
into
RunService
(likely the in-process one for the all-in-one binary). • In `GetActionData`: 1. Validate the request as today. 2. Call
DataProxyService.GetActionData
with the same
action_id
. 3. Convert the
dataproxy.GetActionDataResponse
to
workflow.GetActionDataResponse
(schemas need to be checked for 1:1 compatibility — they currently both use
task.Inputs
/
task.Outputs
so this should be trivial). • Remove the direct
dataStore
/
repo
reads from this RPC once delegation is in place. The URI resolution logic already lives behind
GetActionDataURIs
, which DataProxy calls. • Keep the
runs
RPC registered so existing clients keep working. How was this patch tested? Labels Please add one or more of the following labels to categorize your PR: • added: For new features. • changed: For changes in existing functionality. • deprecated: For soon-to-be-removed features. • removed: For features being removed. • fixed: For any bug fixed. • security: In case of vulnerabilities This is important to improve the readability of release notes. Setup process Screenshots Check all the applicable boxes • I updated the documentation accordingly. • All new and existing tests passed. • All commits are signed-off. Related PRs Docs link •
main
• #6583 • *Delegate RunService.GetActionData to DataProxyService * 👈 flyteorg/flyte