<#7254 fix: serve apps directly via Kourier, drop ...
# flyte-github
a
#7254 fix: serve apps directly via Kourier, drop Traefik IngressRoute Pull request opened by pingsutw Why are the changes needed? Each app deploy was creating a per-app Traefik
IngressRoute
+
Middleware
(
deployIngress
in
app_client.go
) whose only job was to rewrite the
Host
header from our advertised URL (
<name>-<project>-<domain>.<IngressAppsDomain>
) to Knative's hostname (
<ksvc>-<ns>.<BaseDomain>
) so Kourier could route it. For the devbox flow there is no reason to keep those two hostnames different. If we just make the advertised URL match Knative's default domain template, Kourier can serve the request directly — no per-app K8s objects, no Traefik middleware. What changes were proposed in this pull request? • `app/internal/k8s/app_client.go`: delete
deployIngress
/
deleteIngress
, the Traefik GVKs, and all call sites in
Deploy
/
Delete
. Drop the now-unused
unstructured
and
schema
imports. •
app/internal/service/internal_app_service.go
+
app_client.go
(
publicIngress
): when
IngressAppsDomain
is empty, fall back to
BaseDomain
and append
IngressAppsPort
so returned URLs include
:30081
. Service-layer and k8s-layer versions now behave identically. •
charts/flyte-devbox/values.yaml
+ `manager/config.yaml`:
baseDomain: localhost
, keep
ingressAppsPort: 30081
, drop
ingressEntryPoint
/
ingressAppsDomain
. • `charts/flyte-devbox/templates/proxy/traefik-config.yaml`: remove the
apps
entrypoint — Traefik only serves 30080 now. • `docker/devbox-bundled/Makefile`:
setup-knative
sets Knative's
config-domain
to
localhost
(removes
local.flyte.app
) and patches
svc/kourier
in
kourier-system
to
NodePort 30081
. Port-map comment updated. • Regenerated
docker/devbox-bundled/manifests/{complete,dev}.yaml
. Public URL shape is unchanged:
http://<name>-<project>-<domain>.localhost:30081
. Request path is now
browser → :30081 → Kourier → KService
with no Traefik hop. How was this patch tested? •
go build ./app/...
•
go test ./app/internal/k8s/... ./app/internal/service/...
— all pass. • Manually: deploying a Streamlit app and hitting
http://streamlit-hello-v2-flytesnacks-development.localhost:30081/
loads the app. Labels • changed Check all the applicable boxes • All new and existing tests passed. • All commits are signed-off. •
main
• #6583 • #7197 • fix: serve apps directly via Kourier, drop Traefik IngressRoute 👈 flyteorg/flyte