<#7234 fix(helm): set catalog-cache to noop when d...
# flyte-github
a
#7234 fix(helm): set catalog-cache to noop when datacatalog is disabled in flyte-core Pull request opened by nuthalapativarun Tracking issue Closes #7155 Why are the changes needed? When
datacatalog.enabled=false
in the flyte-core Helm chart, the
catalog-cache
configuration still defaults to
type: datacatalog
with
endpoint: datacatalog:89
. Since the datacatalog service is not deployed in this case, every task execution triggers a DNS lookup failure:
Copy code
Failed to check Catalog for previous results:
rpc error: code = Unavailable
  desc = connection error: dial tcp: lookup datacatalog on x.x.x.x:x: no such host
These two related settings are far apart in
values.yaml
(datacatalog toggle at line 273, catalog-cache config buried inside configmaps at line 1055), making it easy to miss the dependency. What changes were proposed in this pull request? In
charts/flyte-core/templates/propeller/configmap.yaml
, the
catalog.yaml
configmap entry is now rendered conditionally: • When
datacatalog.enabled=true
(default): renders the existing
configmap.catalog
value as before, preserving full backward compatibility. • When `datacatalog.enabled=false`: renders
catalog-cache.type: noop
so propeller skips catalog lookups entirely, preventing DNS failures. How was this patch tested? Verified with
helm template
that: •
--set datacatalog.enabled=false
produces
catalog-cache:\n type: noop
•
--set datacatalog.enabled=true
(default) produces the original datacatalog endpoint config unchanged Labels • fixed • I updated the documentation accordingly. • All new and existing tests passed. • All commits are signed-off. flyteorg/flyte