<#7223 Fix missing LinkType for task template log ...
# flyte-github
a
#7223 Fix missing LinkType for task template log links Pull request opened by pingsutw Tracking issue N/A Why are the changes needed? When
InitializeLogPlugins
creates
TemplateLogPlugin
entries from task template metadata log links (e.g., Spark UI, Ray Dashboard), it was not setting
LinkType
or
MessageFormat
. This caused
GetTaskLogs()
to default
LinkType
to
EXTERNAL
(the zero value) instead of
DASHBOARD
, resulting in the API response returning
link_type: "EXTERNAL"
for all task template log links. Note: The
flyte
(v1) branch already has this fix — it was just never ported to v2. What changes were proposed in this pull request? In `flyteplugins/go/tasks/logs/logging_utils.go`: 1. Set
LinkType: core.TaskLog_DASHBOARD.String()
and
MessageFormat: logLink.GetMessageFormat()
when creating
TemplateLogPlugin
from task template log links 2. Add missing
IconUri: dynamicLogLink.IconUri
to dynamic log link plugins How was this patch tested? • Existing unit tests pass (
go test ./flyteplugins/go/tasks/logs/... -count=1
) • Verified the fix matches the v1 branch implementation Check all the applicable boxes • I updated the documentation accordingly. • All new and existing tests passed. • All commits are signed-off. flyteorg/flyte